Re: [Qemu-devel] [PATCH] sdl2: Support all virtio-gpu formats

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

On 08.10.18 20:50, Max Reitz wrote:
> There are some 2D resource formats that can be used through virtio-gpu,
> but which are not supported by SDL2 when used for a scanout; these are
> all alpha-channel formats and also XBGR (RGBX in non-BE pixman).

Oops, it's the other way round.  The virtio-gpu format is RGBX, and the
non-BE pixman (and SDL) constant is XBGR.

Max

> Add these formats in the switch converting pixman to SDL format
> constants so a guest cannot crash the VM by triggering the
> g_assert_not_reached() with an unsupported format.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  ui/sdl2-2d.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c
> index 85484407be..c9df72636a 100644
> --- a/ui/sdl2-2d.c
> +++ b/ui/sdl2-2d.c
> @@ -101,15 +101,24 @@ void sdl2_2d_switch(DisplayChangeListener *dcl,
>      case PIXMAN_r5g6b5:
>          format = SDL_PIXELFORMAT_RGB565;
>          break;
> +    case PIXMAN_a8r8g8b8:
>      case PIXMAN_x8r8g8b8:
>          format = SDL_PIXELFORMAT_ARGB8888;
>          break;
> +    case PIXMAN_a8b8g8r8:
> +    case PIXMAN_x8b8g8r8:
> +        format = SDL_PIXELFORMAT_ABGR8888;
> +        break;
> +    case PIXMAN_r8g8b8a8:
>      case PIXMAN_r8g8b8x8:
>          format = SDL_PIXELFORMAT_RGBA8888;
>          break;
>      case PIXMAN_b8g8r8x8:
>          format = SDL_PIXELFORMAT_BGRX8888;
>          break;
> +    case PIXMAN_b8g8r8a8:
> +        format = SDL_PIXELFORMAT_BGRA8888;
> +        break;
>      default:
>          g_assert_not_reached();
>      }
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]