qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
	konstanty@ieee.org, martin.galvan@tallertechnologies.com
Subject: [Qemu-devel] [PATCH v5 5/7] target_arm: Parameterise the irq lines for armv7m_init
Date: Thu, 16 Oct 2014 22:54:15 +1000	[thread overview]
Message-ID: <d3a8f24c51288f8b4ab3cae23f191cec204a64df.1413463862.git.alistair23@gmail.com> (raw)
In-Reply-To: <cover.1413463862.git.alistair23@gmail.com>

This patch allows the board to specifiy the number of NVIC interrupt
lines when using armv7m_init.

Signed-off-by: Alistair Francis <alistair23@gmail.com>
---
 hw/arm/armv7m.c      | 7 ++++---
 hw/arm/stellaris.c   | 5 ++++-
 include/hw/arm/arm.h | 2 +-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
index 50281f7..7169027 100644
--- a/hw/arm/armv7m.c
+++ b/hw/arm/armv7m.c
@@ -166,14 +166,14 @@ static void armv7m_reset(void *opaque)
    mem_size is in bytes.
    Returns the NVIC array.  */
 
-qemu_irq *armv7m_init(MemoryRegion *system_memory, int mem_size,
+qemu_irq *armv7m_init(MemoryRegion *system_memory, int mem_size, int num_irq,
                       const char *kernel_filename, const char *cpu_model)
 {
     ARMCPU *cpu;
     CPUARMState *env;
     DeviceState *nvic;
     /* FIXME: make this local state.  */
-    static qemu_irq pic[64];
+    qemu_irq *pic = g_new(qemu_irq, num_irq);
     int image_size;
     uint64_t entry;
     uint64_t lowaddr;
@@ -194,11 +194,12 @@ qemu_irq *armv7m_init(MemoryRegion *system_memory, int mem_size,
     armv7m_bitband_init();
 
     nvic = qdev_create(NULL, "armv7m_nvic");
+    qdev_prop_set_uint32(nvic, "num-irq", num_irq);
     env->nvic = nvic;
     qdev_init_nofail(nvic);
     sysbus_connect_irq(SYS_BUS_DEVICE(nvic), 0,
                        qdev_get_gpio_in(DEVICE(cpu), ARM_CPU_IRQ));
-    for (i = 0; i < 64; i++) {
+    for (i = 0; i < num_irq; i++) {
         pic[i] = qdev_get_gpio_in(nvic, i);
     }
 
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index d0c61c5..6fad10f 100644
--- a/hw/arm/stellaris.c
+++ b/hw/arm/stellaris.c
@@ -29,6 +29,8 @@
 #define BP_OLED_SSI  0x02
 #define BP_GAMEPAD   0x04
 
+#define NUM_IRQ_LINES 64
+
 typedef const struct {
     const char *name;
     uint32_t did0;
@@ -1239,7 +1241,8 @@ static void stellaris_init(const char *kernel_filename, const char *cpu_model,
     vmstate_register_ram_global(sram);
     memory_region_add_subregion(system_memory, 0x20000000, sram);
 
-    pic = armv7m_init(system_memory, flash_size, kernel_filename, cpu_model);
+    pic = armv7m_init(system_memory, flash_size, NUM_IRQ_LINES,
+                      kernel_filename, cpu_model);
 
     if (board->dc1 & (1 << 16)) {
         dev = sysbus_create_varargs(TYPE_STELLARIS_ADC, 0x40038000,
diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h
index a112930..94e55a4 100644
--- a/include/hw/arm/arm.h
+++ b/include/hw/arm/arm.h
@@ -15,7 +15,7 @@
 #include "hw/irq.h"
 
 /* armv7m.c */
-qemu_irq *armv7m_init(MemoryRegion *system_memory, int mem_size,
+qemu_irq *armv7m_init(MemoryRegion *system_memory, int mem_size, int num_irq,
                       const char *kernel_filename, const char *cpu_model);
 
 /* arm_boot.c */
-- 
1.9.1

  parent reply	other threads:[~2014-10-16 12:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 12:53 [Qemu-devel] [PATCH v5 0/7] Netduino 2 Machine Model Alistair Francis
2014-10-16 12:53 ` [Qemu-devel] [PATCH v5 1/7] stm32f205_timer: Add the stm32f205 Timer Alistair Francis
2014-10-20  7:18   ` Peter Crosthwaite
2014-10-21  7:05     ` Alistair Francis
2014-10-21  7:40       ` Peter Crosthwaite
2014-10-22  7:20         ` Alistair Francis
2014-10-16 12:53 ` [Qemu-devel] [PATCH v5 2/7] stm32f205_USART: Add the stm32f205 USART Controller Alistair Francis
2014-10-20  7:27   ` Peter Crosthwaite
2014-10-16 12:54 ` [Qemu-devel] [PATCH v5 3/7] stm32f205_SYSCFG: Add the stm32f205 SYSCFG Alistair Francis
2014-10-20  7:35   ` Peter Crosthwaite
2014-10-16 12:54 ` [Qemu-devel] [PATCH v5 4/7] target_arm: Remove memory region init from armv7m_init Alistair Francis
2014-10-20  7:40   ` Peter Crosthwaite
2014-10-16 12:54 ` Alistair Francis [this message]
2014-10-20  7:41   ` [Qemu-devel] [PATCH v5 5/7] target_arm: Parameterise the irq lines for armv7m_init Peter Crosthwaite
2014-10-16 12:54 ` [Qemu-devel] [PATCH v5 6/7] stm32f205: Add the stm32f205 SoC Alistair Francis
2014-10-20  7:47   ` Peter Crosthwaite
2014-10-20 12:30     ` Alistair Francis
2014-10-16 12:54 ` [Qemu-devel] [PATCH v5 7/7] netduino2: Add the Netduino 2 Machine Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3a8f24c51288f8b4ab3cae23f191cec204a64df.1413463862.git.alistair23@gmail.com \
    --to=alistair23@gmail.com \
    --cc=konstanty@ieee.org \
    --cc=martin.galvan@tallertechnologies.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).