From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Juan Quintela" <quintela@redhat.com>
Subject: Re: [RFC PATCH 01/10] migration: Only add migration files to the Meson sourceset
Date: Tue, 6 Oct 2020 13:25:29 +0200 [thread overview]
Message-ID: <d3b004f6-2c21-461c-5455-76ae835547af@redhat.com> (raw)
In-Reply-To: <20201006111219.2300921-2-philmd@redhat.com>
On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
> I'm not sure how that works, but keep the use of Meson
> sourcesets consistent, only add source files.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> migration/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/meson.build b/migration/meson.build
> index b5b71c8060..55c9e1329f 100644
> --- a/migration/meson.build
> +++ b/migration/meson.build
> @@ -14,7 +14,7 @@ libmigration = static_library('migration', sources: migration_files + genh,
> build_by_default: false)
> migration = declare_dependency(link_with: libmigration,
> dependencies: [zlib, qom, io])
> -softmmu_ss.add(migration)
> +softmmu_ss.add(migration_files)
This would compile the file twice. You can just drop this change and
fixup patch 6 instead.
Paolo
next prev parent reply other threads:[~2020-10-06 11:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 11:12 [PATCH 00/10] meson: Move the creation of the library to the main meson.build Philippe Mathieu-Daudé
2020-10-06 11:12 ` [RFC PATCH 01/10] migration: Only add migration files to the Meson sourceset Philippe Mathieu-Daudé
2020-10-06 11:13 ` Philippe Mathieu-Daudé
2020-10-06 11:25 ` Paolo Bonzini [this message]
2020-10-06 11:12 ` [PATCH 02/10] meson.build: Add comments to clarify code organization Philippe Mathieu-Daudé
2020-10-06 11:24 ` Paolo Bonzini
2020-10-06 11:12 ` [PATCH 03/10] meson.build: Sort sourcesets alphabetically Philippe Mathieu-Daudé
2020-10-06 11:12 ` [PATCH 04/10] hw/core: Move the creation of the library to the main meson.build Philippe Mathieu-Daudé
2020-10-06 11:12 ` [PATCH 05/10] chardev: " Philippe Mathieu-Daudé
2020-10-06 11:12 ` [PATCH 06/10] migration: " Philippe Mathieu-Daudé
2020-10-06 11:25 ` Paolo Bonzini
2020-10-06 11:29 ` Philippe Mathieu-Daudé
2020-10-06 11:12 ` [PATCH 07/10] io: " Philippe Mathieu-Daudé
2020-10-06 11:12 ` [PATCH 08/10] crypto: " Philippe Mathieu-Daudé
2020-10-06 11:12 ` [PATCH 09/10] authz: " Philippe Mathieu-Daudé
2020-10-06 11:12 ` [PATCH 10/10] qom: " Philippe Mathieu-Daudé
2020-10-06 11:29 ` [PATCH 00/10] meson: " Paolo Bonzini
2020-10-06 12:48 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b004f6-2c21-461c-5455-76ae835547af@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).