From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, slp@redhat.com
Subject: Re: [qemu-web PATCH v2] Add virtio-blk and virtio-scsi configuration post
Date: Thu, 14 Jan 2021 20:57:26 +0100 [thread overview]
Message-ID: <d3b7952a-284a-9588-afb2-fa080f2fd98c@redhat.com> (raw)
In-Reply-To: <20210114160505.GF292902@stefanha-x1.localdomain>
On 14/01/2021 17.05, Stefan Hajnoczi wrote:
> On Wed, Jan 06, 2021 at 03:04:20PM +0100, Thomas Huth wrote:
>> On 05/01/2021 11.49, Stefan Hajnoczi wrote:
[...]
>>> +Applications that send SCSI commands are better served by the virtio-scsi
>>> +device, which has full SCSI support. SCSI passthrough was removed from the
>>> +Linux virtio-blk driver in v5.6 in favor of using virtio-scsi.
>>
>> Since "passthrough" sounds like a passthrough of real hardware devices, I'd
>> maybe rather say something like: The original virtio-blk devices also
>> included the possibility to handle SCSI commands, but this features was
>> removed from the Linux driver in v5.6 in favor of using virtio-scsi (and is
>> also not available for modern virtio-1.0 devices anymore).
>
> Guest SCSI commands were passed through to the physical LUN but what you
> described sounds more like emulating SCSI commands, which is not what
> the feature did.
Ok, I likely just understood that feature in the wrong way. Looking at the
virtio spec, it just talks about the possibility to send SCSI commands to
the virtio-blk device, but looking at the implementation in QEMU, it seems
more like the way you described, so never mind my comment.
Thomas
next prev parent reply other threads:[~2021-01-14 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 10:49 [qemu-web PATCH v2] Add virtio-blk and virtio-scsi configuration post Stefan Hajnoczi
2021-01-06 14:04 ` Thomas Huth
2021-01-14 16:05 ` Stefan Hajnoczi
2021-01-14 19:57 ` Thomas Huth [this message]
2021-01-14 20:17 ` Laszlo Ersek
2021-01-18 17:03 ` Stefan Hajnoczi
2021-01-18 17:14 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b7952a-284a-9588-afb2-fa080f2fd98c@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).