Re: [Qemu-devel] [PATCH 4/5] checkpatch: bump most warnings to errors

[Thomas Huth <thuth@redhat.com>]

On 10.08.2016 10:22, Paolo Bonzini wrote:
> This only leaves a warning-level message for the extra-long lines
> soft limit.  Everything else is bumped up.
> 
> In the future warnings can be added for checks that can have false
> positives.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/checkpatch.pl | 66 +++++++++++++++++++++++++--------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 714a000..ab08ca2 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1289,11 +1289,11 @@ sub process {
>  			# This is a signoff, if ugly, so do not double report.
>  			$signoff++;
>  			if (!($line =~ /^\s*Signed-off-by:/)) {
> -				WARN("Signed-off-by: is the preferred form\n" .
> +				ERROR("Signed-off-by: is the preferred form\n" .
>  					$herecurr);
>  			}

If you turn this into an ERROR, it's not the "preferred form" anymore,
but the "mandated form". So I'd suggest to either keep it as WARN or to
rephrase the message.

 Thomas