From: Thomas Huth <huth@tuxfamily.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free
Date: Fri, 19 Jan 2018 13:16:52 +0100 [thread overview]
Message-ID: <d3d62aeb-435b-86eb-15a6-fa96f6e28d4c@tuxfamily.org> (raw)
In-Reply-To: <20180119114444.7590-1-laurent@vivier.eu>
On 19.01.2018 12:44, Laurent Vivier wrote:
> t64 is also unconditionally freed after the switch () { ... }
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target/m68k/translate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index f0e86a73d4..ea18df940a 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -969,7 +969,6 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp)
> case OS_DOUBLE:
> tcg_gen_qemu_ld64(t64, addr, index);
> gen_helper_extf64(cpu_env, fp, t64);
> - tcg_temp_free_i64(t64);
> break;
> case OS_EXTENDED:
> if (m68k_feature(s->env, M68K_FEATURE_CF_FPU)) {
>
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
next prev parent reply other threads:[~2018-01-19 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 11:44 [Qemu-devel] [PATCH] target/m68k: fix TCG variable double free Laurent Vivier
2018-01-19 12:16 ` Thomas Huth [this message]
2018-01-22 3:50 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d62aeb-435b-86eb-15a6-fa96f6e28d4c@tuxfamily.org \
--to=huth@tuxfamily.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).