From: "Cédric Le Goater" <clg@kaod.org>
To: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Alistair Francis" <alistair@alistair23.me>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Troy Lee <troy_lee@aspeedtech.com>,
Yunlin Tang <yunlin.tang@aspeedtech.com>
Subject: Re: [PATCH v4 11/16] aspeed/intc: Add AST2700 support
Date: Mon, 3 Jun 2024 09:09:10 +0200 [thread overview]
Message-ID: <d3d97491-fdf6-4fb1-a657-4eb00864ac9f@kaod.org> (raw)
In-Reply-To: <SI2PR06MB5041E687500B2CBFE850B96CFCFF2@SI2PR06MB5041.apcprd06.prod.outlook.com>
>>> +static void aspeed_2700_intc_class_init(ObjectClass *klass, void
>>> +*data) {
>>> + DeviceClass *dc = DEVICE_CLASS(klass);
>>> + AspeedINTCClass *aic = ASPEED_INTC_CLASS(klass);
>>> +
>>> + dc->desc = "ASPEED 2700 INTC Controller";
>>> + aic->num_lines = 32;
>>> + aic->num_ints = 9;
>>
>> Use ASPEED_INTC_NR_INTS ?
>>
> I am considering to support INTC model for future BMC SOCs.
> For example, if the num_ints has been changed to "18" in the future BMC Socs, users only need to update ASPEED_INTC_NR_INTS and
> Create a aspeed_XXXX_intc_class_init to set its "aic->num_ints 18".
> That was why I set aic->num_ints 9 in aspeed_2700_intc_class_init.
OK. This is minor.
Thanks,
C.
next prev parent reply other threads:[~2024-06-03 7:10 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 8:02 [PATCH v4 00/16] Add AST2700 support Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 01/16] aspeed/wdt: " Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 02/16] aspeed/sli: " Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 03/16] aspeed/sdmc: remove redundant macros Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 04/16] aspeed/sdmc: fix coding style Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 05/16] aspeed/sdmc: Add AST2700 support Jamin Lin via
2024-05-27 10:24 ` Philippe Mathieu-Daudé
2024-05-27 11:18 ` Cédric Le Goater
2024-05-27 12:41 ` Philippe Mathieu-Daudé
2024-05-28 1:26 ` Jamin Lin
2024-05-28 6:34 ` Cédric Le Goater
2024-05-28 9:47 ` Jamin Lin
2024-05-28 9:52 ` Cédric Le Goater
2024-05-28 9:54 ` Jamin Lin
2024-05-27 8:02 ` [PATCH v4 06/16] aspeed/smc: correct device description Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 07/16] aspeed/smc: support dma start length and 1 byte length unit Jamin Lin via
2024-05-27 12:52 ` Cédric Le Goater
2024-05-27 8:02 ` [PATCH v4 08/16] aspeed/smc: support 64 bits dma dram address Jamin Lin via
2024-05-27 12:51 ` Cédric Le Goater
2024-05-28 1:34 ` Jamin Lin
2024-05-28 6:37 ` Cédric Le Goater
2024-05-27 16:06 ` Philippe Mathieu-Daudé
2024-05-28 1:38 ` Jamin Lin
2024-05-28 6:53 ` [SPAM] " Cédric Le Goater
2024-05-27 8:02 ` [PATCH v4 09/16] aspeed/smc: Add AST2700 support Jamin Lin via
2024-05-27 15:58 ` Philippe Mathieu-Daudé
2024-05-28 7:02 ` [SPAM] " Cédric Le Goater
2024-06-03 6:24 ` Jamin Lin
2024-06-03 7:22 ` Cédric Le Goater
2024-06-03 9:49 ` Jamin Lin
2024-06-03 9:58 ` Cédric Le Goater
2024-06-03 10:35 ` Jamin Lin
2024-06-03 11:47 ` Cédric Le Goater
2024-05-27 8:02 ` [PATCH v4 10/16] aspeed/scu: " Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 11/16] aspeed/intc: " Jamin Lin via
2024-05-28 8:47 ` Cédric Le Goater
2024-06-03 5:35 ` Jamin Lin
2024-06-03 7:09 ` Cédric Le Goater [this message]
2024-05-27 8:02 ` [PATCH v4 12/16] aspeed/soc: " Jamin Lin via
2024-05-28 8:28 ` Cédric Le Goater
2024-05-31 5:17 ` Jamin Lin
2024-05-31 7:46 ` Cédric Le Goater
2024-05-31 8:24 ` Jamin Lin
2024-05-31 10:56 ` Philippe Mathieu-Daudé
2024-05-28 8:48 ` Cédric Le Goater
2024-05-31 8:57 ` Jamin Lin
2024-05-27 8:02 ` [PATCH v4 13/16] aspeed: Add an AST2700 eval board Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 14/16] aspeed/soc: fix incorrect dram size for AST2700 Jamin Lin via
2024-05-29 8:47 ` Cédric Le Goater
2024-05-30 7:42 ` Jamin Lin
2024-05-30 8:08 ` Cédric Le Goater
2024-05-30 8:11 ` Jamin Lin
2024-05-27 8:02 ` [PATCH v4 15/16] test/avocado/machine_aspeed.py: Add AST2700 test case Jamin Lin via
2024-05-27 8:02 ` [PATCH v4 16/16] docs:aspeed: Add AST2700 Evaluation board Jamin Lin via
2024-05-28 9:56 ` [PATCH v4 00/16] Add AST2700 support Cédric Le Goater
2024-05-28 10:02 ` Jamin Lin
2024-05-28 10:14 ` Cédric Le Goater
2024-05-29 0:47 ` Jamin Lin
2024-06-05 3:47 ` Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d97491-fdf6-4fb1-a657-4eb00864ac9f@kaod.org \
--to=clg@kaod.org \
--cc=alistair@alistair23.me \
--cc=andrew@codeconstruct.com.au \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=troy_lee@aspeedtech.com \
--cc=wainersm@redhat.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).