From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: mrolnik@gmail.com, philmd@linaro.org
Subject: Re: [PATCH 05/17] target/avr: Move cpu register accesses into system memory
Date: Tue, 25 Mar 2025 07:34:42 -0700 [thread overview]
Message-ID: <d3da05a2-a01b-49bd-8d25-4128a408ed03@linaro.org> (raw)
In-Reply-To: <7df3dc8f-c4ad-47fc-96b7-7ddad3274d51@linaro.org>
On 3/25/25 06:48, Richard Henderson wrote:
> On 3/24/25 18:07, Pierrick Bouvier wrote:
>> A simple nit, maybe we could define constant for register names. This way, it can be used
>> in the two switch for read/access.
>
> Which constant?
>
> - The absolute address (0x58-0x5f)
> - The i/o port address (0x38-0x3f)
> - or the region offset (0-7)
>
> ? That's where I got stuck and didn't add such.
>
Something like:
#define RAMPD 0
...
#define SREG 7
#define REG_IOPORT_BASE_ADDR 0x38
#define REG_BASE_ADDR 0x58
And in the switch, we can substract base addresses, so only cases 0..7
are left.
I don't have a strong opinion on names, just thought seeing those 2
address constants + register offset is useful and makes intention clearer.
>> By the way, are there other architectures where cpu registers are mapped in memory like AVR?
>
> Not that I know of.
>
>
> r~
next prev parent reply other threads:[~2025-03-25 14:35 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 17:37 [PATCH 00/17] target/avr: Increase page size Richard Henderson
2025-03-23 17:37 ` [PATCH 01/17] hw/core/cpu: Use size_t for memory_rw_debug len argument Richard Henderson
2025-03-23 21:25 ` Philippe Mathieu-Daudé
2025-03-25 0:43 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 02/17] target/avr: Fix buffer read in avr_print_insn Richard Henderson
2025-03-25 0:52 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 03/17] target/avr: Improve decode of LDS, STS Richard Henderson
2025-03-25 0:53 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 04/17] target/avr: Remove OFFSET_CPU_REGISTERS Richard Henderson
2025-03-23 21:27 ` Philippe Mathieu-Daudé
2025-03-25 0:55 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 05/17] target/avr: Move cpu register accesses into system memory Richard Henderson
2025-03-25 1:07 ` Pierrick Bouvier
2025-03-25 13:48 ` Richard Henderson
2025-03-25 14:34 ` Pierrick Bouvier [this message]
2025-03-23 17:37 ` [PATCH 06/17] target/avr: Use cpu_stb_mmuidx_ra in helper_fullwr Richard Henderson
2025-03-25 1:08 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 07/17] target/avr: Use do_stb in avr_cpu_do_interrupt Richard Henderson
2025-03-23 21:31 ` Philippe Mathieu-Daudé
2025-03-25 1:09 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 08/17] target/avr: Add offset-io cpu property Richard Henderson
2025-03-25 1:10 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 09/17] target/avr: Introduce gen_data_{load,store}_raw Richard Henderson
2025-03-25 1:12 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 10/17] target/avr: Update cpu_sp after push and pop Richard Henderson
2025-03-25 1:36 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 11/17] target/avr: Implement CPUState.memory_rw_debug Richard Henderson
2025-03-23 21:33 ` Philippe Mathieu-Daudé
2025-03-25 1:19 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 12/17] target/avr: Handle offset_io in helper.c Richard Henderson
2025-03-23 21:34 ` Philippe Mathieu-Daudé
2025-03-25 1:20 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 13/17] target/avr: Handle offset_io in avr_cpu_realizefn Richard Henderson
2025-03-23 21:35 ` Philippe Mathieu-Daudé
2025-03-23 21:38 ` Philippe Mathieu-Daudé
2025-03-25 1:20 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 14/17] hw/avr: Set offset_io and increase page size to 1k Richard Henderson
2025-03-25 1:21 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 15/17] hw/avr: Pass mcu_type to class_base_init via .class_data Richard Henderson
2025-03-23 21:38 ` Philippe Mathieu-Daudé
2025-03-25 1:25 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 16/17] hw/avr: Move AtmegaMcuClass to atmega.h Richard Henderson
2025-03-25 1:22 ` Pierrick Bouvier
2025-03-23 17:37 ` [PATCH 17/17] target/avr: Enable TARGET_PAGE_BITS_VARY Richard Henderson
2025-03-25 1:24 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3da05a2-a01b-49bd-8d25-4128a408ed03@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=mrolnik@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).