From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mohamed Mediouni <mohamed@unpredictable.fr>, qemu-devel@nongnu.org
Cc: Mads Ynddal <mads@ynddal.dk>,
qemu-arm@nongnu.org, Cameron Esfahani <dirty@apple.com>,
Peter Maydell <peter.maydell@linaro.org>,
Roman Bolshakov <rbolshakov@ddn.com>,
Alexander Graf <agraf@csgraf.de>,
Phil Dennis-Jordan <phil@philjordan.eu>
Subject: Re: [RFC v2 1/4] hw: vmapple: include missing headers
Date: Mon, 13 Oct 2025 21:02:53 +0200 [thread overview]
Message-ID: <d3e9d489-eb54-4540-9752-f691f6481c40@linaro.org> (raw)
In-Reply-To: <20251007203153.30136-2-mohamed@unpredictable.fr>
On 7/10/25 22:31, Mohamed Mediouni wrote:
> Disablement by default led to:
>
> ../hw/vmapple/vmapple.c:276:39: error: use of undeclared identifier 'GTIMER_VIRT'
> 276 | qdev_connect_gpio_out(cpudev, GTIMER_VIRT,
> | ^
> ../hw/vmapple/vmapple.c:479:54: error: use of undeclared identifier 'QEMU_PSCI_CONDUIT_HVC'
> 479 | object_property_set_int(cpu, "psci-conduit", QEMU_PSCI_CONDUIT_HVC,
> | ^
> ../hw/vmapple/vmapple.c:556:13: error: call to undeclared function 'arm_build_mp_affinity'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 556 | arm_build_mp_affinity(n, GICV3_TARGETLIST_BITS);
> | ^
> 3 errors generated.
>
> pretty quickly.
>
> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
> ---
> hw/vmapple/vmapple.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/vmapple/vmapple.c b/hw/vmapple/vmapple.c
> index 16e6110b68..5928df4411 100644
> --- a/hw/vmapple/vmapple.c
> +++ b/hw/vmapple/vmapple.c
> @@ -51,6 +51,8 @@
> #include "system/reset.h"
> #include "system/runstate.h"
> #include "system/system.h"
> +#include "gtimer.h"
> +#include "cpu.h"
Queued using instead:
#include "target/arm/gtimer.h"
#include "target/arm/cpu.h"
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-10-13 19:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 20:31 [RFC v2 0/4] vmapple: making it work on the latest macOS releaases and Apple M4 Mohamed Mediouni
2025-10-07 20:31 ` [RFC v2 1/4] hw: vmapple: include missing headers Mohamed Mediouni
2025-10-07 21:19 ` Alexander Graf
2025-10-13 19:02 ` Philippe Mathieu-Daudé [this message]
2025-10-07 20:31 ` [RFC v2 2/4] hvf: arm64: add workaround for Apple M4 to run older macOS versions Mohamed Mediouni
2025-10-07 21:12 ` Alexander Graf
2025-10-08 11:35 ` Mohamed Mediouni
2025-10-08 20:00 ` Alexander Graf
2025-10-09 2:35 ` Mohamed Mediouni
2025-10-07 20:31 ` [RFC v2 3/4] vmapple: apple-gfx: make it work on the latest macOS release Mohamed Mediouni
2025-10-07 21:19 ` Alexander Graf
2025-10-08 4:21 ` Philippe Mathieu-Daudé
2025-10-07 20:31 ` [RFC v2 4/4] Revert "hw/arm: Do not build VMapple machine by default" Mohamed Mediouni
2025-10-07 21:13 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e9d489-eb54-4540-9752-f691f6481c40@linaro.org \
--to=philmd@linaro.org \
--cc=agraf@csgraf.de \
--cc=dirty@apple.com \
--cc=mads@ynddal.dk \
--cc=mohamed@unpredictable.fr \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).