Re: [Qemu-devel] [PATCH v1 07/15] iotests: fix 097 when run with qcow

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]

On 03.01.2017 19:27, Daniel P. Berrange wrote:
> The previous commit:
> 
>   commit a3e1505daec31ef56f0489f8c8fff1b8e4ca92bd
>   Author: Eric Blake <eblake@redhat.com>
>   Date:   Mon Dec 5 09:49:34 2016 -0600
> 
>     qcow2: Don't strand clusters near 2G intervals during commit
> 
> extended the 097 test case so that it did two passes, once
> with an internal snapshot, once without.
> 
> qcow (v1) does not support internal snapshots, so this change
> broke test 097 when run against qcow.
> 
> This splits 097 in two, creating a new 173 that tests the
> internal snapshot codepath, effectively putting 097 back
> to its content before the above commit.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  tests/qemu-iotests/097     |  10 +---
>  tests/qemu-iotests/097.out | 125 ++------------------------------------------
>  tests/qemu-iotests/173     | 126 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/173.out | 119 ++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  5 files changed, 251 insertions(+), 130 deletions(-)
>  create mode 100755 tests/qemu-iotests/173
>  create mode 100644 tests/qemu-iotests/173.out

I don't think the effort is worth it, considering that probably
literally nobody is still using qcow -- or so I hope, at least.

Anyway:

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]