From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH] pcie: enable Extended tag field capability
Date: Thu, 17 Oct 2024 21:18:19 +0200 [thread overview]
Message-ID: <d3f61522-afcf-404d-b5d7-ab94c18b59c2@linaro.org> (raw)
In-Reply-To: <20241017125724-mutt-send-email-mst@kernel.org>
W dniu 17.10.2024 o 18:58, Michael S. Tsirkin pisze:
>> diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
>> index 4b2f0805c6..54c0f1ec67 100644
>> --- a/hw/pci/pcie.c
>> +++ b/hw/pci/pcie.c
>> @@ -86,7 +86,8 @@ pcie_cap_v1_fill(PCIDevice *dev, uint8_t port, uint8_t type, uint8_t version)
>> * Specification, Revision 1.1., or subsequent PCI Express Base
>> * Specification revisions.
>> */
>> - pci_set_long(exp_cap + PCI_EXP_DEVCAP, PCI_EXP_DEVCAP_RBER);
>> + pci_set_long(exp_cap + PCI_EXP_DEVCAP, PCI_EXP_DEVCAP_RBER |
>> + PCI_EXP_DEVCAP_EXT_TAG);
>>
>> pci_set_long(exp_cap + PCI_EXP_LNKCAP,
>> (port << PCI_EXP_LNKCAP_PN_SHIFT) |
>
> We can't change capabilities unconditionally.
> It needs at least a machine type compat thing.
Thanks for review. Will look how to handle it better then.
next prev parent reply other threads:[~2024-10-17 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 13:33 [PATCH] pcie: enable Extended tag field capability Marcin Juszkiewicz
2024-10-17 16:58 ` Michael S. Tsirkin
2024-10-17 19:18 ` Marcin Juszkiewicz [this message]
2024-10-18 10:24 ` Marcin Juszkiewicz
2024-10-22 7:34 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f61522-afcf-404d-b5d7-ab94c18b59c2@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).