From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Programmingkid <programmingkidx@gmail.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v2 0/4] cutils: Introduce bundle mechanism
Date: Sat, 26 Feb 2022 22:09:11 +0900 [thread overview]
Message-ID: <d4058fc3-4d61-13bc-b6ac-3bddcb4c34fb@gmail.com> (raw)
In-Reply-To: <CAFEAcA-XgD5yotXLc+kfv3Q0HROnb5owkyi9iZ7Ls1RLV+Jddw@mail.gmail.com>
On 2022/02/26 22:02, Peter Maydell wrote:
> On Sat, 26 Feb 2022 at 12:45, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>>
>> Developers often run QEMU without installing. The bundle mechanism
>> allows to look up files which should be present in installation even in
>> such a situation.
>
> This is supposed to work already -- it is why find_datadir() looks
> at a path based on qemu_get_exec_dir() as well as at the
> CONFIG_QEMU_DATADIR.
>
> If you want to replace that mechanism, you need to explain:
> * under what circumstances it isn't working correctly
> * why we should replace it with a different design rather
> than attempting to fix its bugs
> * why the design you're proposing is the right way to do that
>
> The cover letter is a good place to explain that sort of
> thing, so people understand why the patchset is doing what
> it is before they dive into the detail.
>
> thanks
> -- PMM
datadir is only for pc-bios and does not include icons and
qemu-bridge-helper. find_bundle is a general mechanism which can be used
for any files to be installed.
Regards,
Akihiko Odaki
prev parent reply other threads:[~2022-02-26 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 12:45 [PATCH v2 0/4] cutils: Introduce bundle mechanism Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 1/4] " Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 2/4] datadir: Use " Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 3/4] ui/icons: " Akihiko Odaki
2022-02-26 12:45 ` [PATCH v2 4/4] net: " Akihiko Odaki
2022-02-27 16:23 ` Philippe Mathieu-Daudé
2022-02-26 13:02 ` [PATCH v2 0/4] cutils: Introduce " Peter Maydell
2022-02-26 13:09 ` Akihiko Odaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4058fc3-4d61-13bc-b6ac-3bddcb4c34fb@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).