From: David Hildenbrand <david@redhat.com>
To: Daniil Tatianin <d-tatianin@yandex-team.ru>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "imammedo@redhat.com" <imammedo@redhat.com>,
"sw@weilnetz.de" <sw@weilnetz.de>,
"yc-core@yandex-team.ru" <yc-core@yandex-team.ru>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH v1 2/2] osdep: support mempolicy for preallocation in os_mem_prealloc
Date: Tue, 7 Dec 2021 16:05:39 +0100 [thread overview]
Message-ID: <d40efabf-25d3-56d5-7e5b-ae6a70b5edd1@redhat.com> (raw)
In-Reply-To: <227321638883575@mail.yandex-team.ru>
On 07.12.21 14:58, Daniil Tatianin wrote:
> I believe you're right. Looking at the implementation of
> shmem_alloc_page, it uses the inode policy, which is set via
> vma->set_policy (from the mbind() call in this case). set_mempolicy is
> both useless and redundant here, as thread's
> policy is only ever used in case vma->get_policy returns NULL (which it
> doesn't in our case).
> Sorry for the confusion.
Hi Danlil,
not an issue, the man page is really confusing ... so I was similarly
confused a few months ago until I actually started to dig :)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-12-07 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 7:06 [PATCH v1 1/2] hostmem: use a static size for maxnode, validate policy everywhere Daniil Tatianin
2021-12-07 7:06 ` [PATCH v1 2/2] osdep: support mempolicy for preallocation in os_mem_prealloc Daniil Tatianin
2021-12-07 8:13 ` David Hildenbrand
[not found] ` <227321638883575@mail.yandex-team.ru>
2021-12-07 15:05 ` David Hildenbrand [this message]
2021-12-07 8:31 ` [PATCH v1 1/2] hostmem: use a static size for maxnode, validate policy everywhere David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d40efabf-25d3-56d5-7e5b-ae6a70b5edd1@redhat.com \
--to=david@redhat.com \
--cc=d-tatianin@yandex-team.ru \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).