Re: [PATCH v3 7/8] hw/ide/ahci: fix ahci_write_fis_sdb()

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 9/6/23 16:08, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@wdc.com>
> 
> When there is an error, we need to raise a TFES error irq, see AHCI 1.3.1,
> 5.3.13.1 SDB:Entry.
> 
> If ERR_STAT is set, we jump to state ERR:FatalTaskfile, which will raise
> a TFES IRQ unconditionally, regardless if the I bit is set in the FIS or
> not.
> 
> Thus, we should never raise a normal IRQ after having sent an error IRQ.
> 
> It is valid to signal successfully completed commands as finished in the
> same SDB FIS that generates the error IRQ. The important thing is that
> commands that did not complete successfully (e.g. commands that were
> aborted, do not get the finished bit set).
> 
> Before this commit, there was never a TFES IRQ raised on NCQ error.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
>   hw/ide/ahci.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>