qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	chauser@pullman.com, marcandre.lureau@redhat.com,
	pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] escc: convert Sun mouse to use QemuInputHandler
Date: Tue, 3 Sep 2024 13:43:36 -0700	[thread overview]
Message-ID: <d4409097-f60a-4f7d-adfe-dee8073f176f@linaro.org> (raw)
In-Reply-To: <20240903203846.144354-1-mark.cave-ayland@ilande.co.uk>

On 9/3/24 13:38, Mark Cave-Ayland wrote:
> Update the Sun mouse implementation to use QemuInputHandler instead of the
> legacy qemu_add_mouse_event_handler() function.
> 
> Note that this conversion adds extra sunmouse_* members to ESCCChannelState
> but they are not added to the migration stream (similar to the Sun keyboard
> members). If this were desired in future, the Sun devices should be split
> into separate devices and added to the migration stream there instead.
> 
> Signed-off-by: Mark Cave-Ayland<mark.cave-ayland@ilande.co.uk>
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/2518
> ---
>   hw/char/escc.c         | 88 +++++++++++++++++++++++++++++++-----------
>   include/hw/char/escc.h |  3 ++
>   2 files changed, 69 insertions(+), 22 deletions(-)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2024-09-03 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 20:38 [PATCH v2] escc: convert Sun mouse to use QemuInputHandler Mark Cave-Ayland
2024-09-03 20:43 ` Richard Henderson [this message]
2024-09-03 22:21 ` Carl Hauser via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4409097-f60a-4f7d-adfe-dee8073f176f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=chauser@pullman.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).