From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <eduardo@habkost.net>,
Nicholas Piggin <npiggin@gmail.com>,
Anton Johansson <anjo@rev.ng>,
qemu-ppc@nongnu.org,
Daniel Henrique Barboza <danielhb413@gmail.com>
Subject: Re: [PATCH-for-9.1] target/ppc: Unify TYPE_POWERPC_CPU definition for 32/64-bit
Date: Mon, 25 Mar 2024 08:14:32 +0100 [thread overview]
Message-ID: <d44cb28a-dce1-437d-8b5d-0966140211c4@redhat.com> (raw)
In-Reply-To: <20240322183450.25284-1-philmd@linaro.org>
On 22/03/2024 19.34, Philippe Mathieu-Daudé wrote:
> Apparently there is no wordsize special use with the QOM
> TYPE_POWERPC_CPU typename. Unify 32 and 64-bit with a single
> common definition.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/ppc/cpu-qom.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h
> index 8247fa2336..ed75f1b690 100644
> --- a/target/ppc/cpu-qom.h
> +++ b/target/ppc/cpu-qom.h
> @@ -23,11 +23,7 @@
> #include "exec/gdbstub.h"
> #include "hw/core/cpu.h"
>
> -#ifdef TARGET_PPC64
> -#define TYPE_POWERPC_CPU "powerpc64-cpu"
> -#else
> #define TYPE_POWERPC_CPU "powerpc-cpu"
> -#endif
Have you tried a bunch of migrations with ppc machines from an older QEMU to
a QEMU with this change and back, to make sure that there are no regressions?
Thomas
prev parent reply other threads:[~2024-03-25 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 18:34 [PATCH-for-9.1] target/ppc: Unify TYPE_POWERPC_CPU definition for 32/64-bit Philippe Mathieu-Daudé
2024-03-25 7:14 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44cb28a-dce1-437d-8b5d-0966140211c4@redhat.com \
--to=thuth@redhat.com \
--cc=anjo@rev.ng \
--cc=danielhb413@gmail.com \
--cc=eduardo@habkost.net \
--cc=npiggin@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).