* [PATCH-for-9.1] target/ppc: Unify TYPE_POWERPC_CPU definition for 32/64-bit
@ 2024-03-22 18:34 Philippe Mathieu-Daudé
2024-03-25 7:14 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-22 18:34 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Nicholas Piggin, Thomas Huth, Anton Johansson,
qemu-ppc, Daniel Henrique Barboza, Philippe Mathieu-Daudé
Apparently there is no wordsize special use with the QOM
TYPE_POWERPC_CPU typename. Unify 32 and 64-bit with a single
common definition.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/ppc/cpu-qom.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h
index 8247fa2336..ed75f1b690 100644
--- a/target/ppc/cpu-qom.h
+++ b/target/ppc/cpu-qom.h
@@ -23,11 +23,7 @@
#include "exec/gdbstub.h"
#include "hw/core/cpu.h"
-#ifdef TARGET_PPC64
-#define TYPE_POWERPC_CPU "powerpc64-cpu"
-#else
#define TYPE_POWERPC_CPU "powerpc-cpu"
-#endif
OBJECT_DECLARE_CPU_TYPE(PowerPCCPU, PowerPCCPUClass, POWERPC_CPU)
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH-for-9.1] target/ppc: Unify TYPE_POWERPC_CPU definition for 32/64-bit
2024-03-22 18:34 [PATCH-for-9.1] target/ppc: Unify TYPE_POWERPC_CPU definition for 32/64-bit Philippe Mathieu-Daudé
@ 2024-03-25 7:14 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2024-03-25 7:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eduardo Habkost, Nicholas Piggin, Anton Johansson, qemu-ppc,
Daniel Henrique Barboza
On 22/03/2024 19.34, Philippe Mathieu-Daudé wrote:
> Apparently there is no wordsize special use with the QOM
> TYPE_POWERPC_CPU typename. Unify 32 and 64-bit with a single
> common definition.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/ppc/cpu-qom.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h
> index 8247fa2336..ed75f1b690 100644
> --- a/target/ppc/cpu-qom.h
> +++ b/target/ppc/cpu-qom.h
> @@ -23,11 +23,7 @@
> #include "exec/gdbstub.h"
> #include "hw/core/cpu.h"
>
> -#ifdef TARGET_PPC64
> -#define TYPE_POWERPC_CPU "powerpc64-cpu"
> -#else
> #define TYPE_POWERPC_CPU "powerpc-cpu"
> -#endif
Have you tried a bunch of migrations with ppc machines from an older QEMU to
a QEMU with this change and back, to make sure that there are no regressions?
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-25 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-22 18:34 [PATCH-for-9.1] target/ppc: Unify TYPE_POWERPC_CPU definition for 32/64-bit Philippe Mathieu-Daudé
2024-03-25 7:14 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).