From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] block/backup: disable copy_range for compressed backup
Date: Thu, 1 Aug 2019 13:20:15 +0200 [thread overview]
Message-ID: <d44fa7b5-3f3d-8915-b942-537047b82eca@redhat.com> (raw)
In-Reply-To: <20190730163251.755248-3-vsementsov@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 451 bytes --]
On 30.07.19 18:32, Vladimir Sementsov-Ogievskiy wrote:
> Enabled by default copy_range ignores compress option. It's definitely
> unexpected for user.
>
> It's broken since introduction of copy_range usage in backup in
> 9ded4a011496.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/backup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-01 11:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 16:32 [Qemu-devel] [PATCH 0/3] backup fixes for 4.1? Vladimir Sementsov-Ogievskiy
2019-07-30 16:32 ` [Qemu-devel] [PATCH 1/3] block/backup: deal with zero detection Vladimir Sementsov-Ogievskiy
2019-07-30 18:40 ` John Snow
2019-07-31 10:01 ` Vladimir Sementsov-Ogievskiy
2019-07-31 13:45 ` John Snow
2019-08-01 11:18 ` Max Reitz
2019-08-01 11:18 ` Max Reitz
2019-07-30 16:32 ` [Qemu-devel] [PATCH 2/3] block/backup: disable copy_range for compressed backup Vladimir Sementsov-Ogievskiy
2019-07-30 18:22 ` John Snow
2019-07-31 13:51 ` Vladimir Sementsov-Ogievskiy
2019-08-01 11:20 ` Max Reitz [this message]
2019-08-05 16:05 ` Max Reitz
2019-07-30 16:32 ` [Qemu-devel] [PATCH 3/3] block/backup: refactor write_flags Vladimir Sementsov-Ogievskiy
2019-07-30 18:28 ` John Snow
2019-07-31 16:01 ` Vladimir Sementsov-Ogievskiy
2019-08-01 11:28 ` Max Reitz
2019-08-01 11:32 ` Vladimir Sementsov-Ogievskiy
2019-08-01 11:37 ` Max Reitz
2019-08-01 12:02 ` Vladimir Sementsov-Ogievskiy
2019-08-01 12:21 ` Max Reitz
2019-08-01 12:40 ` Vladimir Sementsov-Ogievskiy
2019-08-01 11:28 ` Max Reitz
2019-07-30 18:41 ` [Qemu-devel] [PATCH 0/3] backup fixes for 4.1? John Snow
2019-07-31 10:29 ` Vladimir Sementsov-Ogievskiy
2019-07-31 13:46 ` John Snow
2019-08-07 23:52 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44fa7b5-3f3d-8915-b942-537047b82eca@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).