From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/5] iotests: Make 083 less flaky
Date: Fri, 10 Nov 2017 16:18:15 +0100 [thread overview]
Message-ID: <d44fc75f-829c-65cd-fc19-04f32d897f8a@redhat.com> (raw)
In-Reply-To: <w51375mv4by.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
On 2017-11-10 11:02, Alberto Garcia wrote:
> On Thu 09 Nov 2017 09:30:24 PM CET, Max Reitz wrote:
>> + echo > "$TEST_DIR/nbd-fault-injector.out"
>> $PYTHON nbd-fault-injector.py $extra_args "$nbd_addr" "$TEST_DIR/nbd-fault-injector.conf" >"$TEST_DIR/nbd-fault-injector.out" 2>&1 &
>
> It seems that in this patch you're indenting with spaces but this file
> uses tabs.
Yes, but tabs are wrong. :-)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-11-10 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 20:30 [Qemu-devel] [PATCH v2 0/5] iotests: Make some tests less flaky Max Reitz
2017-11-09 20:30 ` [Qemu-devel] [PATCH v2 1/5] iotests: Make 030 " Max Reitz
2017-11-09 20:30 ` [Qemu-devel] [PATCH v2 2/5] iotests: Add missing 'blkdebug::' in 040 Max Reitz
2017-11-09 20:30 ` [Qemu-devel] [PATCH v2 3/5] iotests: Make 055 less flaky Max Reitz
2017-11-09 20:30 ` [Qemu-devel] [PATCH v2 4/5] iotests: Make 083 " Max Reitz
2017-11-09 20:58 ` Eric Blake
2017-11-09 21:00 ` Max Reitz
2017-11-10 10:02 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-11-10 15:18 ` Max Reitz [this message]
2017-11-10 15:51 ` Alberto Garcia
2017-11-10 17:29 ` Max Reitz
2017-11-10 18:26 ` Eric Blake
2017-11-09 20:30 ` [Qemu-devel] [PATCH v2 5/5] iotests: Make 136 " Max Reitz
2017-11-09 22:29 ` [Qemu-devel] [PATCH v2 0/5] iotests: Make some tests " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d44fc75f-829c-65cd-fc19-04f32d897f8a@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).