From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01553CAC5A7 for ; Thu, 25 Sep 2025 09:58:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1ij1-0006YE-Bk; Thu, 25 Sep 2025 05:57:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1iix-0006Wx-L3 for qemu-devel@nongnu.org; Thu, 25 Sep 2025 05:57:16 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1iij-0004Ev-Ix for qemu-devel@nongnu.org; Thu, 25 Sep 2025 05:57:11 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-45f2cf99bbbso3262545e9.0 for ; Thu, 25 Sep 2025 02:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758794214; x=1759399014; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b3zkmtwgF8OgRZSVxNZsJWGz7kIKA/pWysAG8vggoYU=; b=LAhPtzAq8dUdDD6m/kNijIOXFxVyAaqo7Zovy38OFA39PfLggN0UNIEuBxG5R0/MHD /zPp4ihYXK2L53ZZp86GEnre5F6kNZGtGdjJ8qWWsJ5E1bFfNhpg9h0iLWobiYOie/oT YhiS/oNosd/tqkg59dn15FQU5Hm8uYlXyKe2uQ9oIaUls1QjG3cVZbsADyt0Q9EjjKkw UtAnhtYVQHPGqpJ6OXpYm84shQEY+Kj0Y6A66iR81do9SHxwd+agRygjZTFKg3xNH8LY 07xgDeGevtQ66qyltIcrDfoXHzzhiMLXFawRb0W7SL3LPn/5kY5op5o0cEz7+yQdhHCt DwSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758794214; x=1759399014; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b3zkmtwgF8OgRZSVxNZsJWGz7kIKA/pWysAG8vggoYU=; b=SfoPtTFds8EotEBJcQINlUQVLvifcaAmCaIVpvWmoUWhFoANxd0NxYo9UHXjfp78pE aDTZeXgFxLHtbkXh6VG+afnOX3LJ5dEfbq6/XrAGlgSx/IRjMhncGhyRHFeDmBtk+JXa tKzzfEYInxp5/wuee8GzwObGG26RxWFv/HHpASP+JZLLIJyd+BV4eieU9g/NMegt8tTw QnOSmhk4hF9K/woN2Tj95jMiZjeclhlZ+hkUTY6a0e/iglpLiI6syvkCVLXunJE4M2Ac cJ6wnvY/AdQ51jXXjhaH82Sq9sX3f0k/X4ks1oDwhbd6bzdCW8ILctWOuJjmXTX7DVu0 oZMA== X-Forwarded-Encrypted: i=1; AJvYcCUpChptn/Tw4zcJBlhKS0W7GwusubM3ft1DkPOCGhnelNvPEE9sGHQmF6TFtz/P4uEodqH1tQSAb8/2@nongnu.org X-Gm-Message-State: AOJu0YxRshJmubnS0pe3O21JDhM6ochRk7YmraP9IplJRxusL1mq6VSY 1hV025c7zbDzYOF01a5oDPzmBh7hm+0fwS/CZnb+QYSAHTH5ckwEqvHpigxg6bHaqIg= X-Gm-Gg: ASbGnctLZLuqvFIkt2q+e0Uc+0A9++61uxYHUh0zLi1+00E7klL2DtxGoKtlFgQdkTm vDnd8ypxTDevsa8Qov9eZTvDXYAsjvVUhB+y2FPgMBQLTXEMWlOCMtieiWkdYBwBxzoDQvy2W+u DCfrOT9Wdyjyo7XAuymSiFshUyZYjrppglOjUc9iv7w4fSIXYPUWJEdyJ7B5+ypEeatD6/JP4v/ Xs59Kas5liC9CV4pFIY8udOUK2409VLSVOpdoII0bo4lqz0kDQcN1z3by2RlKp4aPx7LRhVcarv DK92HWXwrFzOpb60R6dXEhlzu+ek35Sy9dqjGF5eXb2K6/ln3CbaZcWIZdnaUL4bIjFcLO3ykLF WQISBvDFsshOLVWnBLduvqqodpAiG84wacXRFLM86iI7B247Y5z2rl8LrckEPX/Vrxy86mVmiay 31 X-Google-Smtp-Source: AGHT+IFQXlM3WaBbfz+dZa4JeP/4nB5z9+k7VxWSLirBZVaOSSh+6DrF6u4nQuNn52vn3qx3Jptx8w== X-Received: by 2002:a05:600c:8b33:b0:46e:1fc2:f9ba with SMTP id 5b1f17b1804b1-46e32a0d5e7mr32845575e9.25.1758794213831; Thu, 25 Sep 2025 02:56:53 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2a9ac5basm83309395e9.7.2025.09.25.02.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 02:56:53 -0700 (PDT) Message-ID: Date: Thu, 25 Sep 2025 11:56:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 17/23] util: fix interleaving of error prefixes Content-Language: en-US To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-devel@nongnu.org Cc: Hanna Reitz , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Kevin Wolf , qemu-rust@nongnu.org, Richard Henderson , Markus Armbruster , Christian Schoenebeck , qemu-block@nongnu.org, Stefan Weil , "Dr. David Alan Gilbert" , Manos Pitsidianakis , Gerd Hoffmann , devel@lists.libvirt.org, Paolo Bonzini References: <20250925094441.1651372-1-berrange@redhat.com> <20250925094441.1651372-18-berrange@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250925094441.1651372-18-berrange@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/9/25 11:44, Daniel P. Berrangé wrote: > The vreport() function will optionally emit an prefix for error > messages which is output to stderr incrementally. In the event > that two vreport() calls execute concurrently, there is a risk > that the prefix output will interleave. To address this it is > required to take a lock on 'stderr' when outputting errors. > > Signed-off-by: Daniel P. Berrangé > --- > util/error-report.c | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Philippe Mathieu-Daudé