From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/3] Makefile: Fix 'make distclean'
Date: Fri, 8 Mar 2019 15:49:49 +0100 [thread overview]
Message-ID: <d4536c2e-3419-07b0-49a0-ac17a374218a@redhat.com> (raw)
In-Reply-To: <20190308135744.6480-3-peter.maydell@linaro.org>
On 3/8/19 2:57 PM, Peter Maydell wrote:
> We forgot the '-r' option on the rm command to clean up the
> Sphinx .doctrees working directory, which meant that
> "make distclean" fails:
> rm: cannot remove '.doctrees': Is a directory
>
> Add the missing option.
>
> Fixes: 5f71eac06e15b9a3fa1134d446f ("Makefile, configure: Support building rST documentation")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 0194ef7fa55..9fd7f3f9bfb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -691,7 +691,7 @@ distclean: clean
> rm -f docs/interop/qemu-qmp-ref.html docs/interop/qemu-ga-ref.html
> rm -f docs/qemu-block-drivers.7
> rm -f docs/qemu-cpu-models.7
> - rm -f .doctrees
> + rm -rf .doctrees
> $(call clean-manual,devel)
> $(call clean-manual,interop)
> for d in $(TARGET_DIRS); do \
>
next prev parent reply other threads:[~2019-03-08 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 13:57 [Qemu-devel] [PATCH 0/3] Fix various issues with Sphinx build machinery Peter Maydell
2019-03-08 13:57 ` [Qemu-devel] [PATCH 1/3] Makefile: Fix Sphinx documentation builds for in-tree builds Peter Maydell
2019-03-08 14:49 ` Philippe Mathieu-Daudé
2019-03-08 13:57 ` [Qemu-devel] [PATCH 2/3] Makefile: Fix 'make distclean' Peter Maydell
2019-03-08 14:49 ` Philippe Mathieu-Daudé [this message]
2019-03-08 13:57 ` [Qemu-devel] [PATCH 3/3] Makefile: Don't install non-sphinx files in sphinx docs install Peter Maydell
2019-03-08 16:14 ` Philippe Mathieu-Daudé
2019-03-11 12:51 ` [Qemu-devel] [PATCH 0/3] Fix various issues with Sphinx build machinery Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4536c2e-3419-07b0-49a0-ac17a374218a@redhat.com \
--to=philmd@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).