* [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server
@ 2012-12-10 10:36 Uri Lublin
2012-12-12 14:45 ` Uri Lublin
0 siblings, 1 reply; 3+ messages in thread
From: Uri Lublin @ 2012-12-10 10:36 UTC (permalink / raw)
To: qemu-devel
When qxl + vnc are used, a dummy spice_server is initialized.
The spice_server has to be told when the VM runstate changes,
which is what this patch does.
Without it, from qxl_send_events(), the following error message is shown:
qxl_send_events: spice-server bug: guest stopped, ignoring
---
ui/spice-core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 261c6f2..6a6ab12 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -732,6 +732,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
*/
spice_server = spice_server_new();
spice_server_init(spice_server, &core_interface);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
}
return spice_server_add_interface(spice_server, sin);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server
2012-12-10 10:36 [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server Uri Lublin
@ 2012-12-12 14:45 ` Uri Lublin
2012-12-12 15:31 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Uri Lublin @ 2012-12-12 14:45 UTC (permalink / raw)
To: qemu-devel
On 12/10/2012 12:36 PM, Uri Lublin wrote:
> When qxl + vnc are used, a dummy spice_server is initialized.
> The spice_server has to be told when the VM runstate changes,
> which is what this patch does.
>
> Without it, from qxl_send_events(), the following error message is shown:
> qxl_send_events: spice-server bug: guest stopped, ignoring
Signed-off-by: Uri Lublin <uril@redhat.com>
> ---
> ui/spice-core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 261c6f2..6a6ab12 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -732,6 +732,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
> */
> spice_server = spice_server_new();
> spice_server_init(spice_server,&core_interface);
> + qemu_add_vm_change_state_handler(vm_change_state_handler,&spice_server);
> }
>
> return spice_server_add_interface(spice_server, sin);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server
2012-12-12 14:45 ` Uri Lublin
@ 2012-12-12 15:31 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2012-12-12 15:31 UTC (permalink / raw)
To: uril; +Cc: qemu-devel
On 12/12/12 15:45, Uri Lublin wrote:
> On 12/10/2012 12:36 PM, Uri Lublin wrote:
>> When qxl + vnc are used, a dummy spice_server is initialized.
>> The spice_server has to be told when the VM runstate changes,
>> which is what this patch does.
>>
>> Without it, from qxl_send_events(), the following error message is shown:
>> qxl_send_events: spice-server bug: guest stopped, ignoring
>
> Signed-off-by: Uri Lublin <uril@redhat.com>
=== checkpatch complains ===
WARNING: line over 80 characters
#10: FILE: ui/spice-core.c:739:
+ qemu_add_vm_change_state_handler(vm_change_state_handler,
&spice_server);
please fix & resend.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-12 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-10 10:36 [Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server Uri Lublin
2012-12-12 14:45 ` Uri Lublin
2012-12-12 15:31 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).