From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8842BC433F5 for ; Thu, 28 Oct 2021 00:41:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32F71610CA for ; Thu, 28 Oct 2021 00:41:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32F71610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mftTz-0003Tv-3N for qemu-devel@archiver.kernel.org; Wed, 27 Oct 2021 20:41:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mftQN-0001Fk-4a for qemu-devel@nongnu.org; Wed, 27 Oct 2021 20:37:43 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]:53976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mftQL-0004fo-KZ for qemu-devel@nongnu.org; Wed, 27 Oct 2021 20:37:42 -0400 Received: by mail-pj1-x1029.google.com with SMTP id v10so2774311pjr.3 for ; Wed, 27 Oct 2021 17:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EYkZh1xgRyrgqQg09sMU4JHgci0r1fAQCTVgQ6lQ91U=; b=howZWx2TvzL5nltLy6MTcV7oRFRJQLBlp2fUxL59xg1J+zmlz69izg1VIXKy+ngceY Dj62F7qcq1eV0JifeYEUv1tTp7tRbTpIQIdMS+jFXCDP+DUDDdW5n4PO3l/V4ZfmGyaF k/JtVENGzEMVk1cvohxyRukCrXTN8nA+veCtzx6xbLX4B/1+Zs05b0u4v8odVI3VFTSq UZ79WYNjDSil+pdTWRh7bPsbpAHcvzLOLXNQ8UR2mllUOJoF3iznWPU/qn9lWh/mYgHz Yz17TgSBYTJy2PVb/YvOnslbQfDOYoWByQWZibH5YiMwvwKKk51QeWmgULilYqSJ582k M2bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EYkZh1xgRyrgqQg09sMU4JHgci0r1fAQCTVgQ6lQ91U=; b=OYxsUNnPQfublYCuUUJs1Xm6joPioPYAoALO9rT2DErVJMijwzS85qKd/wI4eMlonI 1WY8p1eLtAO0x2hwB7WWsa4pNktIvyvRx1GthEZ4BeC3Unb0wdVoQkQP6WTaTA1xm7P3 shJEcWOpswVUP5N9uMBfZnukUzHtme5iGd8OaxhC6mMhYCgBHsuLnFMjhe+RvIhMTFqw QcpoDQO2IBeW6ljfuzuSm8x4D3Hv85DzMa7pHTO5MI+KQtvOF1FjXVqQwNQMMojxdp0Q 3aJQqqa587GG5K0YNp7oKUiSzSCZSOdCAJbP6uRyJAajzzWzpRbWulw6mGEa5uEGBZBe Zjmg== X-Gm-Message-State: AOAM531NMgFK9tYVQbCnp7ZuOY0G/FIy8bivOys9MpgudYhdxdnz2pdV TTCN2dI6VSJ2uJRSZ2fHbeqzNQ== X-Google-Smtp-Source: ABdhPJx9WZXkw+88+vrAADMACyc2FWCuu3mrYnPntrdrJejUATi7U2Vx7OZCBQMU1keq5VTXCbgCUA== X-Received: by 2002:a17:90b:1bd2:: with SMTP id oa18mr9234337pjb.164.1635381460213; Wed, 27 Oct 2021 17:37:40 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id b24sm861908pgm.26.2021.10.27.17.37.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 17:37:39 -0700 (PDT) Subject: Re: [PATCH v3 08/18] hw/intc/sh_intc: Use existing macro instead of local one To: BALATON Zoltan , qemu-devel@nongnu.org References: <8bcf22e9ec3a823bfec7cff6417015f6659dd0e5.1635371671.git.balaton@eik.bme.hu> From: Richard Henderson Message-ID: Date: Wed, 27 Oct 2021 17:37:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <8bcf22e9ec3a823bfec7cff6417015f6659dd0e5.1635371671.git.balaton@eik.bme.hu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1029.google.com X-Spam_score_int: -48 X-Spam_score: -4.9 X-Spam_bar: ---- X-Spam_report: (-4.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.847, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Magnus Damm , Yoshinori Sato Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/27/21 2:54 PM, BALATON Zoltan wrote: > The INTC_A7 local macro does the same as the A7ADDR from > include/sh/sh.h so use the latter and drop the local macro definition. > > Signed-off-by: BALATON Zoltan > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/intc/sh_intc.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~