From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Cc: "Paul Burton" <pburton@wavecomp.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Helge Deller" <deller@gmx.de>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Antony Pavlov" <antonynpavlov@gmail.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Joel Stanley" <joel@jms.id.au>,
"Alistair Francis" <alistair@alistair23.me>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Beniamino Galvani" <b.galvani@gmail.com>,
qemu-arm@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
"Cédric Le Goater" <clg@kaod.org>,
"Richard Henderson" <rth@twiddle.net>,
"Radoslaw Biernacki" <radoslaw.biernacki@linaro.org>,
"Thomas Huth" <huth@tuxfamily.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Michael Walle" <michael@walle.cc>,
qemu-ppc@nongnu.org,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board
Date: Mon, 21 Oct 2019 19:34:25 +0200 [thread overview]
Message-ID: <d46d1607-eec1-814d-1a02-2100429e198f@redhat.com> (raw)
In-Reply-To: <708cda0d-4e05-4f15-5131-288567e91a4d@linaro.org>
On 10/21/19 7:27 PM, Richard Henderson wrote:
> On 10/20/19 3:56 PM, Philippe Mathieu-Daudé wrote:
>> @@ -73,8 +74,16 @@ static void clipper_init(MachineState *machine)
>> cpus[0]->env.trap_arg1 = 0;
>> cpus[0]->env.trap_arg2 = smp_cpus;
>>
>> + /*
>> + * Main memory region, 0x00.0000.0000. Real hardware supports 32GB,
>> + * but the address space hole reserved at this point is 8TB.
>> + */
>> + memory_region_allocate_system_memory(&ram_region, NULL, "ram",
>> + ram_size);
>> + memory_region_add_subregion(get_system_memory(), 0, &ram_region);
>
> The thing that I don't like about this is that ...
>
>> @@ -849,12 +848,6 @@ PCIBus *typhoon_init(ram_addr_t ram_size, ISABus **isa_bus,
>>
>> *p_rtc_irq = qemu_allocate_irq(typhoon_set_timer_irq, s, 0);
>>
>> - /* Main memory region, 0x00.0000.0000. Real hardware supports 32GB,
>> - but the address space hole reserved at this point is 8TB. */
>> - memory_region_allocate_system_memory(&s->ram_region, NULL, "ram",
>> - ram_size);
>> - memory_region_add_subregion(addr_space, 0, &s->ram_region);
>> -
>> /* TIGbus, 0x801.0000.0000, 1GB. */
>> /* ??? The TIGbus is used for delivering interrupts, and access to
>> the flash ROM. I'm not sure that we need to implement it at all. */
>
> ... previously, it was clear that Typhoon owns the entire address space layout.
> With this moved to dp264.c, the "address space hole" comment is out of context
> and makes no sense.
>
> Would it be too weird to pass in a MemoryRegion* to typhoon_init and leave the
> memory_region_add_subregion() call where it is?
Yes, this will also better match the hardware.
I have a WiP series that first QOM'ify the CY82C693UB southbridge then
the Typhoon northbridge and pass the DRAM MemoryRegion* as a link, so in
the non-QOM form your suggestion is the same. I'll do your change.
next prev parent reply other threads:[~2019-10-21 17:37 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 22:56 [PATCH 00/21] hw: Let the machine be the owner of the system memory Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2019-10-21 16:49 ` Richard Henderson
2019-10-21 20:47 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 02/21] hw/arm/mps2: " Philippe Mathieu-Daudé
2019-10-21 16:50 ` Richard Henderson
2019-10-21 20:47 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 03/21] hw/arm/collie: Create the RAM in the board Philippe Mathieu-Daudé
2019-10-21 16:55 ` Richard Henderson
2019-10-21 20:49 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 04/21] hw/arm/omap2: " Philippe Mathieu-Daudé
2019-10-21 16:59 ` Richard Henderson
2019-10-21 17:18 ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 05/21] hw/arm/omap1: " Philippe Mathieu-Daudé
2019-10-21 17:03 ` Richard Henderson
2019-10-20 22:56 ` [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function Philippe Mathieu-Daudé
2019-10-21 17:04 ` Richard Henderson
2019-10-21 20:51 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 07/21] hw: Drop QOM ownership on memory_region_allocate_system_memory() calls Philippe Mathieu-Daudé
2019-10-21 23:18 ` Alistair Francis
2019-10-22 9:47 ` Artyom Tarasenko
2019-10-20 22:56 ` [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board Philippe Mathieu-Daudé
2019-10-21 8:53 ` Philippe Mathieu-Daudé
2019-10-21 17:27 ` Richard Henderson
2019-10-21 17:34 ` Philippe Mathieu-Daudé [this message]
2019-10-20 22:56 ` [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument Philippe Mathieu-Daudé
2019-10-21 7:27 ` Thomas Huth
2019-10-21 8:32 ` Philippe Mathieu-Daudé
2019-10-21 23:19 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 10/21] hw/core: Let the machine be the owner of the system memory Philippe Mathieu-Daudé
2019-10-21 23:20 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 11/21] hw/alpha: " Philippe Mathieu-Daudé
2019-10-21 17:14 ` Richard Henderson
2019-10-21 17:19 ` Richard Henderson
2019-10-21 17:26 ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 12/21] hw/arm: " Philippe Mathieu-Daudé
2019-10-21 9:22 ` Peter Maydell
2019-10-21 9:33 ` Philippe Mathieu-Daudé
2019-10-21 9:39 ` Peter Maydell
2019-10-21 10:24 ` Philippe Mathieu-Daudé
2019-10-21 14:57 ` Dr. David Alan Gilbert
2021-02-03 16:05 ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 13/21] hw/cris: " Philippe Mathieu-Daudé
2019-10-21 17:28 ` Richard Henderson
2019-10-21 20:56 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 14/21] hw/hppa: " Philippe Mathieu-Daudé
2019-10-21 17:29 ` Richard Henderson
2019-10-21 20:56 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 15/21] hw/i386: " Philippe Mathieu-Daudé
2019-10-21 17:29 ` Richard Henderson
2019-10-21 20:56 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 16/21] hw/lm32: " Philippe Mathieu-Daudé
2019-10-21 17:30 ` Richard Henderson
2019-10-21 20:57 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 17/21] hw/m68k: " Philippe Mathieu-Daudé
2019-10-21 7:28 ` Thomas Huth
2019-10-21 17:31 ` Richard Henderson
2019-10-21 20:57 ` Alistair Francis
2019-10-20 22:56 ` [PATCH 18/21] hw/mips: " Philippe Mathieu-Daudé
2019-10-21 6:25 ` Aleksandar Markovic
2019-10-21 8:34 ` Philippe Mathieu-Daudé
2019-10-21 10:56 ` Aleksandar Markovic
2019-10-21 11:05 ` Philippe Mathieu-Daudé
2019-10-21 11:10 ` Aleksandar Markovic
2019-10-21 11:28 ` Philippe Mathieu-Daudé
2019-10-21 12:10 ` Aleksandar Markovic
2019-10-21 19:24 ` [EXTERNAL][PATCH " Aleksandar Markovic
2019-10-20 22:56 ` [PATCH 19/21] hw/ppc: " Philippe Mathieu-Daudé
2019-10-21 0:44 ` David Gibson
2019-10-21 17:33 ` Richard Henderson
2019-10-20 22:56 ` [PATCH 20/21] hw/sparc: " Philippe Mathieu-Daudé
2019-10-21 17:33 ` Richard Henderson
2019-10-20 22:56 ` [PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory has machine owner Philippe Mathieu-Daudé
2019-10-21 17:41 ` Richard Henderson
2019-10-21 21:00 ` Alistair Francis
2019-10-21 0:03 ` [PATCH 00/21] hw: Let the machine be the owner of the system memory no-reply
2019-10-21 8:52 ` Philippe Mathieu-Daudé
2019-10-21 14:31 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d46d1607-eec1-814d-1a02-2100429e198f@redhat.com \
--to=philmd@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alistair@alistair23.me \
--cc=amarkovic@wavecomp.com \
--cc=andrew.smirnov@gmail.com \
--cc=andrew@aj.id.au \
--cc=antonynpavlov@gmail.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=chouteau@adacore.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=hpoussin@reactos.org \
--cc=huth@tuxfamily.org \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jcd@tribudubois.net \
--cc=joel@jms.id.au \
--cc=leif.lindholm@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pburton@wavecomp.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=radoslaw.biernacki@linaro.org \
--cc=richard.henderson@linaro.org \
--cc=robh@kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).