From: Richard Henderson <richard.henderson@linaro.org>
To: LIU Zhiwei <zhiwei_liu@c-sky.com>,
alistair23@gmail.com, chihmin.chao@sifive.com,
palmer@dabbelt.com
Cc: wenmeng_zhang@c-sky.com, qemu-riscv@nongnu.org,
linux-csky@vger.kernel.org, wxy194768@alibaba-inc.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/1] target/riscv: add vector integer operations
Date: Thu, 27 Feb 2020 21:46:06 -0800 [thread overview]
Message-ID: <d47523ad-52e3-b0a8-a47d-c91442fbe48d@linaro.org> (raw)
In-Reply-To: <20200226024352.7719-1-zhiwei_liu@c-sky.com>
On 2/25/20 6:43 PM, LIU Zhiwei wrote:
> Signed-off-by: LIU Zhiwei <zhiwei_liu@c-sky.com>
> ---
> target/riscv/helper.h | 395 +++++++
> target/riscv/insn32.decode | 127 +++
> target/riscv/insn_trans/trans_rvv.inc.c | 671 +++++++++++-
> target/riscv/vector_helper.c | 1308 ++++++++++++++++++++++-
> 4 files changed, 2462 insertions(+), 39 deletions(-)
This patch is too large and needs splitting.
> -static bool vext_check_overlap_mask(DisasContext *s, uint32_t vd, bool vm)
> +static bool vext_check_overlap_mask(DisasContext *s, uint32_t vd, bool vm,
> + bool widen)
> {
> - return !(s->lmul > 1 && vm == 0 && vd == 0);
> + return (vm != 0 || vd != 0) ? true : (!widen && (s->lmul == 0));
> }
>
Best to move the addition of widen back to the patch that introduced this function.
The "? true :" is a funny way to write ||.
r~
next prev parent reply other threads:[~2020-02-28 5:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 2:43 [PATCH v3 1/1] target/riscv: add vector integer operations LIU Zhiwei
2020-02-28 5:46 ` Richard Henderson [this message]
2020-02-28 6:19 ` LIU Zhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d47523ad-52e3-b0a8-a47d-c91442fbe48d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair23@gmail.com \
--cc=chihmin.chao@sifive.com \
--cc=linux-csky@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wenmeng_zhang@c-sky.com \
--cc=wxy194768@alibaba-inc.com \
--cc=zhiwei_liu@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).