From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [PATCH 5/5] hw/i2c/versatile_i2c: Rename versatile_i2c -> arm_sbcon_i2c
Date: Mon, 9 Jan 2023 09:12:15 -0800 [thread overview]
Message-ID: <d4760a0c-0c01-c5de-34cb-f5e381e51fc9@linaro.org> (raw)
In-Reply-To: <e901bc9d-1c3c-5cc0-7a59-e55816babffa@linaro.org>
On 1/9/23 01:29, Philippe Mathieu-Daudé wrote:
> On 9/1/23 10:17, Philippe Mathieu-Daudé wrote:
>> This device model started with the Versatile board, named
>> TYPE_VERSATILE_I2C, then ended up renamed TYPE_ARM_SBCON_I2C
>> as per the official "ARM SBCon two-wire serial bus interface"
>> description from:
>> https://developer.arm.com/documentation/dui0440/b/programmer-s-reference/two-wire-serial-bus-interface--sbcon
>>
>> Use the latter name as a better description.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> hw/arm/Kconfig | 4 ++--
>> hw/i2c/Kconfig | 2 +-
>> hw/i2c/{versatile_i2c.c => arm_sbcon_i2c.c} | 24 ++++++++++-----------
>> hw/i2c/meson.build | 2 +-
>> 4 files changed, 16 insertions(+), 16 deletions(-)
>> rename hw/i2c/{versatile_i2c.c => arm_sbcon_i2c.c} (81%)
>
>
>> diff --git a/hw/i2c/versatile_i2c.c b/hw/i2c/arm_sbcon_i2c.c
>> similarity index 81%
>> rename from hw/i2c/versatile_i2c.c
>> rename to hw/i2c/arm_sbcon_i2c.c
>
> Sorry I forgot this hunk:
>
> -- >8 --
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7a40d4d865..a3c7748505 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -940,6 +940,7 @@ M: Peter Maydell <peter.maydell@linaro.org>
> L: qemu-arm@nongnu.org
> S: Maintained
> F: hw/*/versatile*
> +F: hw/i2c/arm_sbcon_i2c.c
> F: include/hw/i2c/arm_sbcon_i2c.h
> F: hw/misc/arm_sysctl.c
> F: docs/system/arm/versatile.rst
>
> ---
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-01-09 17:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 9:17 [PATCH 0/5] hw/i2c: Rename TYPE_VERSATILE_I2C -> TYPE_ARM_SBCON_I2C Philippe Mathieu-Daudé
2023-01-09 9:17 ` [PATCH 1/5] hw/i2c/versatile_i2c: Drop useless casts from void * to pointer Philippe Mathieu-Daudé
2023-01-09 17:08 ` Richard Henderson
2023-01-09 9:17 ` [PATCH 2/5] hw/i2c/versatile_i2c: Replace VersatileI2CState -> ArmSbconI2CState Philippe Mathieu-Daudé
2023-01-09 17:09 ` Richard Henderson
2023-01-09 9:17 ` [PATCH 3/5] hw/i2c/versatile_i2c: Replace TYPE_VERSATILE_I2C -> TYPE_ARM_SBCON_I2C Philippe Mathieu-Daudé
2023-01-09 17:10 ` Richard Henderson
2023-01-09 9:17 ` [PATCH 4/5] hw/i2c/versatile_i2c: Use ARM_SBCON_I2C() macro Philippe Mathieu-Daudé
2023-01-09 17:11 ` Richard Henderson
2023-01-09 9:17 ` [PATCH 5/5] hw/i2c/versatile_i2c: Rename versatile_i2c -> arm_sbcon_i2c Philippe Mathieu-Daudé
2023-01-09 9:29 ` Philippe Mathieu-Daudé
2023-01-09 17:12 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4760a0c-0c01-c5de-34cb-f5e381e51fc9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).