qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/3] libvhost-user: fix cast warnings on 32 bits
Date: Tue, 14 May 2019 13:50:13 +0200	[thread overview]
Message-ID: <d495e630-df57-85f6-d38a-5d844af52202@redhat.com> (raw)
In-Reply-To: <20190514104126.6294-2-marcandre.lureau@redhat.com>

On 5/14/19 12:41 PM, Marc-André Lureau wrote:
> Fixes warnings:
>  warning: cast to pointer from integer of different size
>  [-Wint-to-pointer-cast]
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  contrib/libvhost-user/libvhost-user.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c
> index 74d42177c5..40443a3daa 100644
> --- a/contrib/libvhost-user/libvhost-user.c
> +++ b/contrib/libvhost-user/libvhost-user.c
> @@ -621,7 +621,7 @@ vu_set_mem_table_exec_postcopy(VuDev *dev, VhostUserMsg *vmsg)
>           * data that's already arrived in the shared process.
>           * TODO: How to do hugepage
>           */
> -        ret = madvise((void *)dev_region->mmap_addr,
> +        ret = madvise((void *)(uintptr_t)dev_region->mmap_addr,
>                        dev_region->size + dev_region->mmap_offset,
>                        MADV_DONTNEED);
>          if (ret) {
> @@ -633,7 +633,7 @@ vu_set_mem_table_exec_postcopy(VuDev *dev, VhostUserMsg *vmsg)
>           * in neighbouring pages.
>           * TODO: Turn this backon later.
>           */
> -        ret = madvise((void *)dev_region->mmap_addr,
> +        ret = madvise((void *)(uintptr_t)dev_region->mmap_addr,
>                        dev_region->size + dev_region->mmap_offset,
>                        MADV_NOHUGEPAGE);
>          if (ret) {
> @@ -666,7 +666,7 @@ vu_set_mem_table_exec_postcopy(VuDev *dev, VhostUserMsg *vmsg)
>          DPRINT("%s: region %d: Registered userfault for %llx + %llx\n",
>                  __func__, i, reg_struct.range.start, reg_struct.range.len);
>          /* Now it's registered we can let the client at it */
> -        if (mprotect((void *)dev_region->mmap_addr,
> +        if (mprotect((void *)(uintptr_t)dev_region->mmap_addr,
>                       dev_region->size + dev_region->mmap_offset,
>                       PROT_READ | PROT_WRITE)) {
>              vu_panic(dev, "failed to mprotect region %d for postcopy (%s)",
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  reply	other threads:[~2019-05-14 11:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 10:41 [Qemu-devel] [PATCH v4 0/3] Add vhost-user-input Marc-André Lureau
2019-05-14 10:41 ` [Qemu-devel] [PATCH v4 1/3] libvhost-user: fix cast warnings on 32 bits Marc-André Lureau
2019-05-14 11:50   ` Philippe Mathieu-Daudé [this message]
2019-05-14 10:41 ` [Qemu-devel] [PATCH v4 2/3] libvhost-user: fix -Werror=format= on ppc64 Marc-André Lureau
2019-05-14 11:53   ` Philippe Mathieu-Daudé
2019-05-14 12:33     ` Marc-André Lureau
2019-05-22  5:23       ` Gerd Hoffmann
2019-05-22 13:06         ` Marc-André Lureau
2019-05-14 10:41 ` [Qemu-devel] [PATCH v4 3/3] contrib: add vhost-user-input Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d495e630-df57-85f6-d38a-5d844af52202@redhat.com \
    --to=philmd@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).