Re: [Qemu-devel] [PATCH V2 2/3] COLO-compare: Optimize compare_common and compare_tcp

[Jason Wang <jasowang@redhat.com>]

On 2017年03月02日 16:15, Zhang Chen wrote:
>
>
> On 03/02/2017 03:51 PM, Jason Wang wrote:
>>
>>
>> On 2017年02月28日 14:11, Zhang Chen wrote:
>>>>
>>>
>>> OK, How about this?
>>>
>>> +    /*
>>> +     * Because of ppkt and spkt are both in the same connection,
>>> +     * The ppkt's src ip, dst ip, src port, dst port, ip_proto all are
>>> +     * same with spkt. In addition, IP header's Identification is a 
>>> random
>>> +     * field, we can handle it in IP fragmentation function later.
>>> +     * So we just compare the ip payload here. we ignored all IP 
>>> header
>>> +     * include other field like TOS,TTL,IP Checksum.
>>> +     */
>>>
>>> Thanks
>>> Zhang Chen
>>
>> But this does not explain why we can ignore those fields.
>
> +    /*
> +     * Because of ppkt and spkt are both in the same connection,
> +     * The ppkt's src ip, dst ip, src port, dst port, ip_proto all are
> +     * same with spkt. In addition, IP header's Identification is a 
> random
> +     * field, we can handle it in IP fragmentation function later.
> +     * COLO just concern the response net packet payload from primary 
> guest
> +     * and secondary guest are same or not, So we ignored all IP 
> header include
> +     * other field like TOS,TTL,IP Checksum. we only need to compare
> +     * the ip payload here.
> +     */
>
> How about this fixed comments?
>
> Thanks
> Zhang Chen
>
>

Looks ok.

Thanks

>>
>> Thanks
>>
>>
>>
>