From: Zenghui Yu <yuzenghui@huawei.com>
To: <elena.ufimtseva@oracle.com>, <jag.raman@oracle.com>,
<john.g.johnson@oracle.com>, <stefanha@redhat.com>
Cc: berrange@redhat.com, qemu-trivial@nongnu.org, mjt@tls.msk.ru,
qemu-devel@nongnu.org, laurent@vivier.eu,
wanghaibin.wang@huawei.com, philmd@redhat.com
Subject: Re: [PATCH v3] multi-process: Initialize variables declared with g_auto*
Date: Tue, 6 Apr 2021 22:00:03 +0800 [thread overview]
Message-ID: <d4a03c50-12db-f44c-7d6a-d2baba77f164@huawei.com> (raw)
In-Reply-To: <20210312112143.1369-1-yuzenghui@huawei.com>
[+Stefan]
On 2021/3/12 19:21, Zenghui Yu wrote:
> Quote docs/devel/style.rst (section "Automatic memory deallocation"):
>
> * Variables declared with g_auto* MUST always be initialized,
> otherwise the cleanup function will use uninitialized stack memory
>
> Initialize @name properly to get rid of the compilation error (using
> gcc-7.3.0 on CentOS):
>
> ../hw/remote/proxy.c: In function 'pci_proxy_dev_realize':
> /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: 'name' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> g_free (*pp);
> ^~~~~~~~~~~~
> ../hw/remote/proxy.c:350:30: note: 'name' was declared here
> g_autofree char *name;
> ^~~~
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210312112143.1369-1-yuzenghui@huawei.com>
Ping for 6.0, thanks.
next prev parent reply other threads:[~2021-04-06 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 11:21 [PATCH v3] multi-process: Initialize variables declared with g_auto* Zenghui Yu
2021-03-12 13:54 ` Philippe Mathieu-Daudé
2021-03-15 5:48 ` Miroslav Rezanina
2021-03-15 6:20 ` Zenghui Yu
2021-03-15 6:32 ` Miroslav Rezanina
2021-04-06 14:00 ` Zenghui Yu [this message]
2021-04-26 13:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a03c50-12db-f44c-7d6a-d2baba77f164@huawei.com \
--to=yuzenghui@huawei.com \
--cc=berrange@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).