From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21B6C433E0 for ; Wed, 3 Mar 2021 13:59:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 728A764E7C for ; Wed, 3 Mar 2021 13:59:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 728A764E7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHS2X-000562-Do for qemu-devel@archiver.kernel.org; Wed, 03 Mar 2021 08:59:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHRyr-0007ta-PI for qemu-devel@nongnu.org; Wed, 03 Mar 2021 08:56:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHRyp-00031o-9R for qemu-devel@nongnu.org; Wed, 03 Mar 2021 08:56:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614779758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wfAESWlDsOVbALTd/coIK2jpJnq1gMwI/305QB0rDG4=; b=c8TIMp0s+EfvJ4x3JODyevMjSILIhkT1O0Y91voZLrjnVfiBXEqwDsueBaIWb7L1V3tqjh 3o3prfiqRdl7IkoMZurNlFTV/nHAEQFCTDLipZPFvTb1VT0LzW7sS1bMCecbfqSZNJU1mM BbgpR8vPY4QjOEV2gYbkXotfaPSVqL4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-vlRYbJ3fPi6-0eLepO30ZA-1; Wed, 03 Mar 2021 08:55:56 -0500 X-MC-Unique: vlRYbJ3fPi6-0eLepO30ZA-1 Received: by mail-wm1-f71.google.com with SMTP id y9so1827911wma.4 for ; Wed, 03 Mar 2021 05:55:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wfAESWlDsOVbALTd/coIK2jpJnq1gMwI/305QB0rDG4=; b=PCXaBWudfcEIiLpfZAJXiRq04uo3Nfu0tY4VL9RnnJYpQzk0sH8uxjAtoyNJ5vXtgy bNMGWuUVXehMgtGL4mh1bkx6Ujw+/Xg1LFlI902+9c88HQWmyab2X9e9eTOG6yjmBjkV 3VyCptB4t7mLoshwU9bkvqew8d18odpB7oisgg/6Z7mw/90o7jCIoyfnyhT6ExIFqC8+ /vezT/DB88hFn/CCMBeEfMTQFeq1IBAihPw3tltteLXg6IqXiY9id7nZGqNJ16CeHy26 lphVGL+8uO+U7NjSqWs/5os5y9e3dCi3fSEN9Gu+dn5o9gmY1UKpKhcM5HqRFcYud99S Ocjw== X-Gm-Message-State: AOAM532CES+Gs7EX8ctcO+ji8F0touwtJiUFksFUHlhODfMaR2fbQy6g V+h5d5vyR5fIlnx3ia0JXOE6kr0vsn3umsFvbcveKjdeeelMfzlMnYzu5qyF9Wq4rIMa7/jPq1C txMrfX1Ai+nF0y05AQTPEzh+ikdn1Jfrd87zWYRX34IY6Lnutedah3m2pgtcvGjQDjJ0= X-Received: by 2002:a5d:4441:: with SMTP id x1mr27764606wrr.56.1614779754942; Wed, 03 Mar 2021 05:55:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKvb1pm50hR8W3nXMuxJgKNXDGpU2TH/XNbN2zUY4z/+C/wylTfDYukp36+zr6fR3Cy1uUeg== X-Received: by 2002:a5d:4441:: with SMTP id x1mr27764584wrr.56.1614779754657; Wed, 03 Mar 2021 05:55:54 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n186sm5915040wmn.22.2021.03.03.05.55.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Mar 2021 05:55:54 -0800 (PST) Subject: Re: [PATCH v2] qemu-config: add error propagation to qemu_config_parse To: Markus Armbruster References: <20210226170816.231173-1-pbonzini@redhat.com> <871rcwjql7.fsf@dusky.pond.sub.org> From: Paolo Bonzini Message-ID: Date: Wed, 3 Mar 2021 14:55:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <871rcwjql7.fsf@dusky.pond.sub.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/03/21 14:48, Markus Armbruster wrote: > Reviewed-by: Markus Armbruster > > But please consider avoiding it anyway. It does make for a smaller patch, so I'll use that as an excuse instead of me being old school. I'll clean it up in a separate patch. Paolo