From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1746C432C1 for ; Wed, 25 Sep 2019 04:16:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87A6421655 for ; Wed, 25 Sep 2019 04:16:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87A6421655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCyjN-0005h4-Ku for qemu-devel@archiver.kernel.org; Wed, 25 Sep 2019 00:16:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50418) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCyhi-0004na-Su for qemu-devel@nongnu.org; Wed, 25 Sep 2019 00:15:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCyhe-0001KH-9E for qemu-devel@nongnu.org; Wed, 25 Sep 2019 00:15:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49968) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCyhe-0001Jf-3S for qemu-devel@nongnu.org; Wed, 25 Sep 2019 00:14:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9B46F18C4290; Wed, 25 Sep 2019 04:14:56 +0000 (UTC) Received: from [10.72.12.148] (ovpn-12-148.pek2.redhat.com [10.72.12.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2ADE5D9CC; Wed, 25 Sep 2019 04:14:52 +0000 (UTC) Subject: Re: [PATCH v3] vhost-user: save features if the char dev is closed To: Adrian Moreno , qemu-devel@nongnu.org References: <20190924162044.11414-1-amorenoz@redhat.com> From: Jason Wang Message-ID: Date: Wed, 25 Sep 2019 12:14:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190924162044.11414-1-amorenoz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Wed, 25 Sep 2019 04:14:56 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ddstreet@canonical.com, Pei Zhang , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2019/9/25 =E4=B8=8A=E5=8D=8812:20, Adrian Moreno wrote: > That way the state can be correctly restored when the device is opened > again. This might happen if the backend is restarted. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=3D1738768 > Reported-by: Pei Zhang > Fixes: 6ab79a20af3a (do not call vhost_net_cleanup() on running net fro= m char user event) > Cc: ddstreet@canonical.com > Cc: Michael S. Tsirkin > > Signed-off-by: Adrian Moreno > --- > net/vhost-user.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/vhost-user.c b/net/vhost-user.c > index 51921de443..014199d600 100644 > --- a/net/vhost-user.c > +++ b/net/vhost-user.c > @@ -235,6 +235,10 @@ static void chr_closed_bh(void *opaque) > =20 > s =3D DO_UPCAST(NetVhostUserState, nc, ncs[0]); > =20 > + if (s->vhost_net) { > + s->acked_features =3D vhost_net_get_acked_features(s->vhost_ne= t); > + } > + > qmp_set_link(name, false, &err); > =20 > qemu_chr_fe_set_handlers(&s->chr, NULL, NULL, net_vhost_user_event= , Acked-by: Jason Wang