From: "Naveen N Rao (AMD)" <naveen@kernel.org>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Nikunj A Dadhania" <nikunj@amd.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Michael Roth" <michael.roth@amd.com>,
"Roy Hopkins" <roy.hopkins@randomman.co.uk>,
"Srikanth Aithal" <srikanth.aithal@amd.com>
Subject: [PATCH v3 7/9] target/i386: SEV: Add support for enabling Secure TSC SEV feature
Date: Tue, 28 Oct 2025 16:13:32 +0530 [thread overview]
Message-ID: <d4ca5df3474b2c6a7969c0547fcbfe4d8a88b027.1761648149.git.naveen@kernel.org> (raw)
In-Reply-To: <cover.1761648149.git.naveen@kernel.org>
Add support for enabling Secure TSC VMSA SEV feature in SEV-SNP guests
through a new "secure-tsc" boolean property on SEV-SNP guest objects. By
default, KVM uses the host TSC frequency for Secure TSC.
Sample command-line:
-machine q35,confidential-guest-support=sev0 \
-object sev-snp-guest,id=sev0,cbitpos=51,reduced-phys-bits=1,secure-tsc=on
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Co-developed-by: Ketan Chaturvedi <Ketan.Chaturvedi@amd.com>
Signed-off-by: Ketan Chaturvedi <Ketan.Chaturvedi@amd.com>
Co-developed-by: Nikunj A Dadhania <nikunj@amd.com>
Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
Signed-off-by: Naveen N Rao (AMD) <naveen@kernel.org>
---
target/i386/sev.h | 1 +
target/i386/sev.c | 13 +++++++++++++
qapi/qom.json | 6 +++++-
3 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/target/i386/sev.h b/target/i386/sev.h
index 8e09b2ce1976..87e73034ad15 100644
--- a/target/i386/sev.h
+++ b/target/i386/sev.h
@@ -46,6 +46,7 @@ bool sev_snp_enabled(void);
#define SVM_SEV_FEAT_SNP_ACTIVE BIT(0)
#define SVM_SEV_FEAT_DEBUG_SWAP BIT(5)
+#define SVM_SEV_FEAT_SECURE_TSC BIT(9)
typedef struct SevKernelLoaderContext {
char *setup_data;
diff --git a/target/i386/sev.c b/target/i386/sev.c
index 2cea2661cc03..af8222b8ceb3 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -3122,6 +3122,16 @@ sev_snp_guest_set_host_data(Object *obj, const char *value, Error **errp)
memcpy(finish->host_data, blob, len);
}
+static bool sev_snp_guest_get_secure_tsc(Object *obj, Error **errp)
+{
+ return is_sev_feature_set(SEV_COMMON(obj), SVM_SEV_FEAT_SECURE_TSC);
+}
+
+static void sev_snp_guest_set_secure_tsc(Object *obj, bool value, Error **errp)
+{
+ sev_set_feature(SEV_COMMON(obj), SVM_SEV_FEAT_SECURE_TSC, value);
+}
+
static void
sev_snp_guest_class_init(ObjectClass *oc, const void *data)
{
@@ -3157,6 +3167,9 @@ sev_snp_guest_class_init(ObjectClass *oc, const void *data)
object_class_property_add_str(oc, "host-data",
sev_snp_guest_get_host_data,
sev_snp_guest_set_host_data);
+ object_class_property_add_bool(oc, "secure-tsc",
+ sev_snp_guest_get_secure_tsc,
+ sev_snp_guest_set_secure_tsc);
}
static void
diff --git a/qapi/qom.json b/qapi/qom.json
index e89d11ce45ad..c7dd2dd1b095 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -1101,6 +1101,9 @@
# firmware. Set this to true to disable the use of VCEK.
# (default: false) (since: 9.1)
#
+# @secure-tsc: enable Secure TSC
+# (default: false) (since 10.2)
+#
# Since: 9.1
##
{ 'struct': 'SevSnpGuestProperties',
@@ -1112,7 +1115,8 @@
'*id-auth': 'str',
'*author-key-enabled': 'bool',
'*host-data': 'str',
- '*vcek-disabled': 'bool' } }
+ '*vcek-disabled': 'bool',
+ '*secure-tsc': 'bool' } }
##
# @TdxGuestProperties:
--
2.51.0
next prev parent reply other threads:[~2025-10-28 10:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 10:43 [PATCH v3 0/9] target/i386: SEV: Add support for enabling VMSA SEV features Naveen N Rao (AMD)
2025-10-28 10:43 ` [PATCH v3 1/9] target/i386: SEV: Generalize handling of SVM_SEV_FEAT_SNP_ACTIVE Naveen N Rao (AMD)
2025-10-28 10:43 ` [PATCH v3 2/9] target/i386: SEV: Ensure SEV features are only set through qemu cli or IGVM Naveen N Rao (AMD)
2025-10-28 10:43 ` [PATCH v3 3/9] target/i386: SEV: Consolidate SEV feature validation to common init path Naveen N Rao (AMD)
2025-10-28 10:43 ` [PATCH v3 4/9] target/i386: SEV: Validate that SEV-ES is enabled when VMSA features are used Naveen N Rao (AMD)
2025-10-28 10:43 ` [PATCH v3 5/9] target/i386: SEV: Enable use of KVM_SEV_INIT2 for SEV-ES guests Naveen N Rao (AMD)
2025-10-28 10:43 ` [PATCH v3 6/9] target/i386: SEV: Add support for enabling debug-swap SEV feature Naveen N Rao (AMD)
2025-10-28 10:43 ` Naveen N Rao (AMD) [this message]
2025-10-28 10:43 ` [PATCH v3 8/9] target/i386: SEV: Add support for setting TSC frequency for Secure TSC Naveen N Rao (AMD)
2025-11-06 12:09 ` Markus Armbruster
2025-11-07 8:51 ` Naveen N Rao
2025-11-07 9:49 ` Markus Armbruster
2025-11-10 10:18 ` Naveen N Rao
2025-11-07 9:59 ` Daniel P. Berrangé
2025-11-10 10:12 ` Naveen N Rao
2025-10-28 10:43 ` [PATCH v3 9/9] target/i386: SEV: Refactor check_sev_features() Naveen N Rao (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4ca5df3474b2c6a7969c0547fcbfe4d8a88b027.1761648149.git.naveen@kernel.org \
--to=naveen@kernel.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=michael.roth@amd.com \
--cc=mtosatti@redhat.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roy.hopkins@randomman.co.uk \
--cc=srikanth.aithal@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).