From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehKis-0006fF-Vu for qemu-devel@nongnu.org; Thu, 01 Feb 2018 14:45:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehKho-0004un-NB for qemu-devel@nongnu.org; Thu, 01 Feb 2018 14:40:38 -0500 References: <4a4cf18c47fbbd1147fb8e425d23157bb205e0fe.1516978645.git.berto@igalia.com> From: Max Reitz Message-ID: Date: Thu, 1 Feb 2018 20:34:26 +0100 MIME-Version: 1.0 In-Reply-To: <4a4cf18c47fbbd1147fb8e425d23157bb205e0fe.1516978645.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nt6r5hL8h4NNIjZ5poPHUvVeUrpvGUkay" Subject: Re: [Qemu-devel] [PATCH v3 29/39] qcow2: Prepare expand_zero_clusters_in_l1() for adding L2 slice support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Eric Blake , Anton Nefedov , "Denis V . Lunev" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Nt6r5hL8h4NNIjZ5poPHUvVeUrpvGUkay From: Max Reitz To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Eric Blake , Anton Nefedov , "Denis V . Lunev" Message-ID: Subject: Re: [PATCH v3 29/39] qcow2: Prepare expand_zero_clusters_in_l1() for adding L2 slice support References: <4a4cf18c47fbbd1147fb8e425d23157bb205e0fe.1516978645.git.berto@igalia.com> In-Reply-To: <4a4cf18c47fbbd1147fb8e425d23157bb205e0fe.1516978645.git.berto@igalia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2018-01-26 15:59, Alberto Garcia wrote: > Adding support for L2 slices to expand_zero_clusters_in_l1() needs > (among other things) an extra loop that iterates over all slices of > each L2 table. >=20 > Putting all changes in one patch would make it hard to read because > all semantic changes would be mixed with pure indentation changes. >=20 > To make things easier this patch simply creates a new block and > changes the indentation of all lines of code inside it. Thus, all > modifications in this patch are cosmetic. There are no semantic > changes and no variables are renamed yet. The next patch will take > care of that. >=20 > Signed-off-by: Alberto Garcia > --- > block/qcow2-cluster.c | 187 ++++++++++++++++++++++++++----------------= -------- > 1 file changed, 96 insertions(+), 91 deletions(-) Reviewed-by: Max Reitz --Nt6r5hL8h4NNIjZ5poPHUvVeUrpvGUkay Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlpza8ISHG1yZWl0ekBy ZWRoYXQuY29tAAoJEPQH2wBh1c9AZkAH/R+ckJADSBnmqKwgA3TRuumgZKvuSte4 wcBw2w3JSi0sZINi1KyNYnS8Ju6kc51+hnv6VIQI+6edB7UfFT6cyT9STryOx1ah B34BJmAu31IS6i85K7L6ymh2m0HdbVGhl+4fXV59ir2EMw6bkhmdOXuqojUUInFu muT/Xbi4GMMTVjTn7U6J7LZKKftqDG4/jzHh6U+QV3nPgXtLBgIgHpV7QgJd+7jm tdWuBMIttZ2HKSETRi5f1NszJrVSZB43uuraY3OKHZlPcku+7pen7Swv7JjxyVIL wFlYWYiPw1yO3vEXlMOXsx9UjZ2on5eqt6k0Ix/7N755Ss3Ozhl5HsU= =ifti -----END PGP SIGNATURE----- --Nt6r5hL8h4NNIjZ5poPHUvVeUrpvGUkay--