From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline
Date: Thu, 22 Nov 2018 09:14:50 +0100 [thread overview]
Message-ID: <d4ef817b-8dda-e4dc-56d5-0b2890707df5@redhat.com> (raw)
In-Reply-To: <8a8dd805-7ec7-1cf5-afc3-ac78d54b1501@redhat.com>
On 2018-11-21 19:38, Philippe Mathieu-Daudé wrote:
>
>
> On 21/11/18 19:27, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> scripts/checkpatch.pl | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index eccd656c41..d27bc51f8c 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -2802,7 +2802,8 @@ sub process {
>> info_vreport|
>> error_report|
>> warn_report|
>> - info_report}x;
>> + info_report|
>> + g_test_message}x;
>
> This perl file use <tab> here, shouldn't we keep the same style?
+1
Apart from that:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-11-22 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 18:27 [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline Paolo Bonzini
2018-11-21 18:38 ` Philippe Mathieu-Daudé
2018-11-22 8:14 ` Thomas Huth [this message]
2018-11-22 13:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4ef817b-8dda-e4dc-56d5-0b2890707df5@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).