From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79F56CD484E for ; Wed, 12 Nov 2025 21:55:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vJImx-00038l-Cm; Wed, 12 Nov 2025 16:54:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJI3u-0000m0-62 for qemu-devel@nongnu.org; Wed, 12 Nov 2025 16:07:31 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vJI3p-0001rR-Tt for qemu-devel@nongnu.org; Wed, 12 Nov 2025 16:07:28 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-47118259fd8so1019475e9.3 for ; Wed, 12 Nov 2025 13:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762981644; x=1763586444; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ndvKFCJtXmZXWNjsWlnfM9pmpLT2hMmXPRvFvrdoK9k=; b=YlHkoj+gqamG+NyS4lEHQbC72PVQR2ADAIFIHBHYyYondHN3ccREX/kAXO0aWpxZ2Y 8s8a93v7GUj8WoG1x8nUUArH72P5zm81buKoRXP2GFOtrc8OKroSj2cR2G5JfiYw6cHO vASWLw4DROlZ/FgainN5lIgeiDXztbxuP/surhy6uGBoppFt/wlCW7GvqycZ1XmQ1cFa eWpK29XqrFz4RJHTCPT4KBfpVENG7YOyCWRLIB5RKfhKmPSdyNtr8U9VurhLPsHmFOep ULeTYjCJZ0DwYN4rh47Xz65JMqGCaibGnR+vfUW5KKe0b48JML/rcCMQtpZ3YRWEki9U c4Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762981644; x=1763586444; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ndvKFCJtXmZXWNjsWlnfM9pmpLT2hMmXPRvFvrdoK9k=; b=Pho10bCp9ufsD2hkmmPntyIGghoyNZf9fU866t7igvew2+qNmIcvilZ2WVqqUjP2Fq um7sB35FfQx8xrpvsFaBz37cPBY/V8cVxBxGPyijmsiOw56ksZmaqiDVgO/KSwBghna8 57L47Whj+wU8El9ictHzQMmwxj/iwEWxGl9gXgC/L0CRbdPED/slgDTx+lhpnbuu2mLL r7/hEKao9MeSwSodhiIUb2cNe1LaQndfWht8D8ZHx01NA4XxVYsHsfQPq/ALV7vC/7kr 7Mvlc4zbPjy0yUIXw/XXsWZSs7MwY4jQOxcPObH1DxkOaFsuzyKkPyOp2F/G3l1m5oXL TKUQ== X-Forwarded-Encrypted: i=1; AJvYcCXNRnqTtMhw9Vf6mQigvaudQuP/VnwrCe5qTafkm6mqJ2DzqopiFpz208cINcFE/X4iUzimDDyKetCM@nongnu.org X-Gm-Message-State: AOJu0YzdVowAVuewZw8SQkizOpWMLZ+aHYrWIH0M3/QGRMqwecHUjhpq 0PSugzceTPooq7ci+AbGVwbMhgpetLJlpm2IGiPDmQW2rRY7IFhiiJiJ0gCVTqrUwgE= X-Gm-Gg: ASbGnctLXfqrJtzACt3EdEENhRYs1TKjUW6FUhvDd1QYEwN4NTH1mLETtWwY007EnCF Quh/e2eKNh6SpEN5WcGw4XNLfz+wO9SykyDr3c+bS7bN5h6bZeKnfyamCrBNg0hxpXAyKXLhzOh ihvNXImxtX6W2vd3/Q2A/rBqbu5IsJOUGbOtSuj8RI4aDXLeFtAFwoQh4sPF5o3UyNVtYOrWzfM 8y7iaPzwvLxuetmFRjmF8udkEBvl+vaZanGcRyitZo3eTkTF3GZhdL+fqTQJENbx2pPtVT0samB HFix/kwi6tMlaM4FCltcr8dQ+924S5h4m6uX+6MQrqSnX6djzsf7Dm1a3L7hNow5vCU7CbpFjDC Ets1HH2ugxtyY7nBGmgtsBax55D95sF161LAC9Ljx8+kSPxLLgVlxzBoFTXWoCutSojzDoClXrJ uxfo4oU8hdAzvvkiE4tSkEAwL1LDlhzPimoyGR2FS3g5A= X-Google-Smtp-Source: AGHT+IGtaSx6QtlDHy/EycHh0/ZhW1Mmm/5WCyQeOiw9mC05LvLWss/kOLCaCs1PZ52vi6bPz95ITQ== X-Received: by 2002:a05:6000:310b:b0:42b:3b4c:f411 with SMTP id ffacd0b85a97d-42b4bdb06f1mr4248875f8f.36.1762981643683; Wed, 12 Nov 2025 13:07:23 -0800 (PST) Received: from [192.168.69.210] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b2e96441dsm28506596f8f.23.2025.11.12.13.07.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 13:07:23 -0800 (PST) Message-ID: Date: Wed, 12 Nov 2025 22:07:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] target/arm/kvm: add kvm-psci-version vcpu property Content-Language: en-US To: Sebastian Ott , Peter Maydell , Paolo Bonzini , Eric Auger Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev References: <20251112181357.38999-1-sebott@redhat.com> <20251112181357.38999-3-sebott@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20251112181357.38999-3-sebott@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Sebastian, On 12/11/25 19:13, Sebastian Ott wrote: > Provide a kvm specific vcpu property to override the default > (as of kernel v6.13 that would be PSCI v1.3) PSCI version emulated > by kvm. Current valid values are: 0.1, 0.2, 1.0, 1.1, 1.2, and 1.3 > > Note: in order to support PSCI v0.1 we need to drop vcpu > initialization with KVM_CAP_ARM_PSCI_0_2 in that case. > > Signed-off-by: Sebastian Ott > --- > docs/system/arm/cpu-features.rst | 5 +++ > target/arm/cpu.h | 6 +++ > target/arm/kvm.c | 64 +++++++++++++++++++++++++++++++- > 3 files changed, 74 insertions(+), 1 deletion(-) > diff --git a/target/arm/kvm.c b/target/arm/kvm.c > index 0d57081e69..e91b1abfb8 100644 > --- a/target/arm/kvm.c > +++ b/target/arm/kvm.c > @@ -484,6 +484,49 @@ static void kvm_steal_time_set(Object *obj, bool value, Error **errp) > ARM_CPU(obj)->kvm_steal_time = value ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF; > } > > +struct psci_version { > + uint32_t number; > + const char *str; > +}; > + > +static const struct psci_version psci_versions[] = { > + { QEMU_PSCI_VERSION_0_1, "0.1" }, > + { QEMU_PSCI_VERSION_0_2, "0.2" }, > + { QEMU_PSCI_VERSION_1_0, "1.0" }, > + { QEMU_PSCI_VERSION_1_1, "1.1" }, > + { QEMU_PSCI_VERSION_1_2, "1.2" }, > + { QEMU_PSCI_VERSION_1_3, "1.3" }, > + { -1, NULL }, > +}; > @@ -505,6 +548,12 @@ void kvm_arm_add_vcpu_properties(ARMCPU *cpu) > kvm_steal_time_set); > object_property_set_description(obj, "kvm-steal-time", > "Set off to disable KVM steal time."); > + > + object_property_add_str(obj, "kvm-psci-version", kvm_get_psci_version, > + kvm_set_psci_version); > + object_property_set_description(obj, "kvm-psci-version", > + "Set PSCI version. " > + "Valid values are 0.1, 0.2, 1.0, 1.1, 1.2, 1.3"); Could we enumerate from psci_versions[] here? > } Thanks, Phil.