From: Richard Henderson <richard.henderson@linaro.org>
To: Alistair Francis <alistair.francis@wdc.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: alistair23@gmail.com, bmeng.cn@gmail.com, palmer@dabbelt.com
Subject: Re: [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions
Date: Wed, 4 Nov 2020 08:30:04 -0800 [thread overview]
Message-ID: <d4f57237-518e-4bf8-f31e-988251f1689d@linaro.org> (raw)
In-Reply-To: <189ac3e53ef2854824d18aad7074c6649f17de2c.1604464950.git.alistair.francis@wdc.com>
On 11/3/20 8:43 PM, Alistair Francis wrote:
> +#ifndef CONFIG_USER_ONLY
> +static void check_access(DisasContext *ctx) {
Newline before {.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-11-04 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 4:43 [PATCH v4 0/5] Fix the Hypervisor access functions Alistair Francis
2020-11-04 4:43 ` [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode Alistair Francis
2020-11-04 16:24 ` Richard Henderson
2020-11-04 4:43 ` [PATCH v4 2/5] target/riscv: Set the virtualised MMU mode when doing hyp accesses Alistair Francis
2020-11-04 4:43 ` [PATCH v4 3/5] target/riscv: Remove the HS_TWO_STAGE flag Alistair Francis
2020-11-04 4:43 ` [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions Alistair Francis
2020-11-04 16:30 ` Richard Henderson [this message]
2020-11-04 4:43 ` [PATCH v4 5/5] target/riscv: Split the Hypervisor execute load helpers Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4f57237-518e-4bf8-f31e-988251f1689d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).