From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNh8G-0006Pp-1E for qemu-devel@nongnu.org; Fri, 16 Nov 2018 11:38:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNh8F-0001ky-CH for qemu-devel@nongnu.org; Fri, 16 Nov 2018 11:38:12 -0500 References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> From: Paolo Bonzini Message-ID: Date: Fri, 16 Nov 2018 17:37:54 +0100 MIME-Version: 1.0 In-Reply-To: <20181116172919.43f3e27d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Samuel Ortiz Cc: qemu-devel@nongnu.org, Peter Maydell , Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , Shannon Zhao , qemu-arm@nongnu.org, Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson On 16/11/18 17:29, Igor Mammedov wrote: > General suggestions for this series: > 1. Preferably don't do multiple changes within a patch > neither post huge patches (unless it's pure code movement). > (it's easy to squash patches later it necessary) > 2. Start small, pick a table generalize it and send as > one small patchset. Tables are often independent > and it's much easier on both author/reviewer to agree upon > changes and rewrite it if necessary. How would that be done? This series is on the bigger side, agreed, but most of it is really just code movement. It's a starting point, having a generic ACPI library is way beyond what this is trying to do. Paolo > 3. when you think about refactoring acpi into a generic API > think about it as routines that go into a separate library > (pure acpi spec code) and qemu/acpi glue routines and > divide them correspondingly.