From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, mdroth@linux.vnet.ibm.com, ct@flyingcircus.io
Subject: Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem
Date: Fri, 3 Feb 2017 10:31:36 -0800 [thread overview]
Message-ID: <d4fc2724-6ad7-8006-318b-989855dbc575@redhat.com> (raw)
In-Reply-To: <03b2194a-ea37-c025-53c2-53b030b593f6@kamp.de>
On 03/02/2017 00:20, Peter Lieven wrote:
> Am 02.02.2017 um 22:41 schrieb Paolo Bonzini:
>>
>> On 31/01/2017 07:36, Peter Lieven wrote:
>>> the current implementation fails if we try to freeze an
>>> already frozen filesystem. This can happen if a filesystem
>>> is mounted more than once (e.g. with a bind mount).
>>>
>>> Suggested-by: Christian Theune <ct@flyingcircus.io>
>>> Cc: qemu-stable@nongnu.org
>>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> What happens when you thaw?
>>
>> Paolo
>
> If you try to THAW an unfrozen FS you get EINVAL.
> The current code thaws until an error is returned.
>
> So it should work as is.
>
> If you feel uncomfortable with the EBUSY approach. The other idea would
> be to track all devices which have been successfully frozen and skip consecutive
> tries to freeze them.
No, just asking.
Reeviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2017-02-03 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 15:36 [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem Peter Lieven
2017-02-02 21:41 ` Paolo Bonzini
2017-02-03 8:18 ` Christian Theune
2017-02-03 8:20 ` Peter Lieven
2017-02-03 8:22 ` Christian Theune
2017-02-03 8:36 ` Peter Lieven
2017-02-03 18:31 ` Paolo Bonzini [this message]
2017-02-17 13:02 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4fc2724-6ad7-8006-318b-989855dbc575@redhat.com \
--to=pbonzini@redhat.com \
--cc=ct@flyingcircus.io \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).