From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZieB-0005zR-63 for qemu-devel@nongnu.org; Fri, 03 Feb 2017 13:31:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZie9-0004GF-1r for qemu-devel@nongnu.org; Fri, 03 Feb 2017 13:31:47 -0500 References: <1485876994-14555-1-git-send-email-pl@kamp.de> <03b2194a-ea37-c025-53c2-53b030b593f6@kamp.de> From: Paolo Bonzini Message-ID: Date: Fri, 3 Feb 2017 10:31:36 -0800 MIME-Version: 1.0 In-Reply-To: <03b2194a-ea37-c025-53c2-53b030b593f6@kamp.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, mdroth@linux.vnet.ibm.com, ct@flyingcircus.io On 03/02/2017 00:20, Peter Lieven wrote: > Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: >> >> On 31/01/2017 07:36, Peter Lieven wrote: >>> the current implementation fails if we try to freeze an >>> already frozen filesystem. This can happen if a filesystem >>> is mounted more than once (e.g. with a bind mount). >>> >>> Suggested-by: Christian Theune >>> Cc: qemu-stable@nongnu.org >>> Signed-off-by: Peter Lieven >> What happens when you thaw? >> >> Paolo > > If you try to THAW an unfrozen FS you get EINVAL. > The current code thaws until an error is returned. > > So it should work as is. > > If you feel uncomfortable with the EBUSY approach. The other idea would > be to track all devices which have been successfully frozen and skip consecutive > tries to freeze them. No, just asking. Reeviewed-by: Paolo Bonzini