From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1DQ7k2-0007ba-Uw
	for qemu-devel@nongnu.org; Mon, 25 Apr 2005 13:51:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1DQ7k1-0007bO-IX
	for qemu-devel@nongnu.org; Mon, 25 Apr 2005 13:51:30 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1DQ7k1-0007W2-FS
	for qemu-devel@nongnu.org; Mon, 25 Apr 2005 13:51:29 -0400
Received: from [80.91.229.2] (helo=ciao.gmane.org)
	by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16)
	(Exim 4.34) id 1DQ7ln-00072A-8O
	for qemu-devel@nongnu.org; Mon, 25 Apr 2005 13:53:19 -0400
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1DQ7c5-0001r5-2U
	for qemu-devel@nongnu.org; Mon, 25 Apr 2005 19:43:17 +0200
Received: from p54a10c29.dip0.t-ipconnect.de ([84.161.12.41])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 25 Apr 2005 19:43:17 +0200
Received: from hcz by p54a10c29.dip0.t-ipconnect.de with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 25 Apr 2005 19:43:17 +0200
From: "Heike C. Zimmerer" <nospam05q1@gmx.net>
Date: Mon, 25 Apr 2005 19:47:22 +0200
Message-ID: <d4ja65$j7e$1@sea.gmane.org>
References: <20050425111532.GA2554@dizzy.ath.cx>
	<20050425170752.GA20078@jbrown.mylinuxbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: news <news@sea.gmane.org>
Subject: [Qemu-devel] Re: [patch] option -no-tsc for i386 with speedstep
Reply-To: hcz@hczim.de, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

"Jim C. Brown" <jma5@umd.edu> writes:

> I just want to point out that your patches break qemu for almost every platform
> other than i386.
> [..]
> You probably want to do this, because notsc is only declared for the i386
> platform.
>
>  int64_t cpu_get_real_ticks(void)
>  {
>      int64_t val;
> +#ifdef __i386__
> +    if (notsc) {
> +	return get_clock();
> +    }
> +#endif
>      asm volatile ("rdtsc" : "=A" (val));
>      return val;
>  }

His patch gets inserted after an '#elif defined(__i386__)' directive
(at least the part cited above).

- Heike