From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages
Date: Wed, 1 Jul 2020 16:20:08 +0200 [thread overview]
Message-ID: <d507200e-07ca-1849-30cb-9aed70161b2c@redhat.com> (raw)
In-Reply-To: <CAFEAcA9T1NGyi0g-DN+KGxpJwepWLfapDaWKVePhMEfeHvk5mA@mail.gmail.com>
On 20/06/20 17:04, Peter Maydell wrote:
> On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic
> <aleksandar.qemu.devel@gmail.com> wrote:
>>
>> It is odd that we inform user that, for example, his current working
>> directory is not kernel root, when, in face, we mean qemu root.
>>
>> Replace that and few other similar odd user messages.
>>
>> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
>> ---
>> scripts/checkpatch.pl | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Regardless of my comments on the cover letter, for user facing
> messages this makes sense, especially since it's only 3 lines.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM
>
Queued, thanks.
paolo
next prev parent reply other threads:[~2020-07-01 14:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 13:32 [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming Aleksandar Markovic
2020-06-20 13:32 ` [PATCH 1/2] checkpatch: Rename top_of_kernel_tree() to top_of_qemu_tree() Aleksandar Markovic
2020-06-20 13:32 ` [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages Aleksandar Markovic
2020-06-20 15:04 ` Peter Maydell
2020-07-01 14:20 ` Paolo Bonzini [this message]
2020-07-01 14:26 ` Aleksandar Markovic
2020-07-01 12:57 ` Aleksandar Markovic
2020-06-20 14:25 ` [PATCH 0/2] checkpatch: Do appropriate kernel->qemu renaming Peter Maydell
2020-06-20 15:09 ` Aleksandar Markovic
2020-06-20 15:20 ` Aleksandar Markovic
2020-06-23 8:24 ` Stefan Hajnoczi
2020-06-23 8:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d507200e-07ca-1849-30cb-9aed70161b2c@redhat.com \
--to=pbonzini@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).