From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20802C07E99 for ; Fri, 9 Jul 2021 16:30:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E71E613AB for ; Fri, 9 Jul 2021 16:30:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E71E613AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1tO3-0004JT-QS for qemu-devel@archiver.kernel.org; Fri, 09 Jul 2021 12:29:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1tMG-0008DH-Hy; Fri, 09 Jul 2021 12:28:08 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:50041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1tME-0000qL-Mk; Fri, 09 Jul 2021 12:28:08 -0400 Received: from [192.168.100.1] ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MEmMt-1lw3fm3FbX-00GM1t; Fri, 09 Jul 2021 18:28:01 +0200 Subject: Re: [PATCH] util/guest-random: Fix size arg to tail memcpy To: Mark Nelson , qemu-devel@nongnu.org References: <20210709120600.11080-1-mdnelson8@gmail.com> From: Laurent Vivier Message-ID: Date: Fri, 9 Jul 2021 18:28:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210709120600.11080-1-mdnelson8@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:Ks5CrzMX8+uo4i9A0N/pOCw4gm2eAAd2QUPyYwRefLGYWD2lIeU z96XfFvgDeo7jvJX7glvyY6FfaxIwqjk1lQZqutmJ9US9HwUACTbiX0ieeWeIsmAjSNzHnR K60GBTKuW70Jk3Pl/8Q0a9qQrepwDlTauw0ul/dQR4jQl/GVkzIGpgLLFQRYtu4VnJ0Cg5b dvK1Z8QqGBcv9Jrah60iw== X-UI-Out-Filterresults: notjunk:1;V03:K0:PPxMjIpoK7E=:GNnPMQhXW3iC9Mn5Vw5ItG WNGvihxwR4nq/ZukAh3khiPfae6CTAbueE6nW2pxdENh5nxK7VqwYaccq/OSHck3EOiM1CUsY 8CyCHme0lpb+yabYiFw9JQpnbex5P+OGuVvs00udgApK+EQoxcVYgtuFEqmUtP/PV8jV2R/oy RFX/+lZ7j9EU6/ccE6hob3Zl+SDSCsbKbwJh/cBZi5EhULpoQjyHAc60NGTaJCzCuJl1qMdnc 2iVewkIKCDkUI+k6ssufGjVjtfyE5yFvfiGIbEMr1GejPuaQL2Dcjn3xC8xhy7M13Xm1ONkDU 2M//fTVghYDFZ7+4vuQ78Rvz+oXb8dhKa4KZK2DU1no0fgRnCE+PYU3CSKDQsMOD7/BW4G7mv /7hgozp98MsdogupPl1re5KSgGfeBiwfYV2HjpOmmTXzWE4tB19yj0uKJIVhEUNhf60+Fsgqe HTSEAr5w0TlQ62JMMCvWJnRA33nuyncA0J2b8laDIsaPrjgVx+yKMXzzrGYkDWD3UWNgJtZFe z5YW8Px4ndlZ0240rR0SBIiE+QRwKXU10aSZWrTt87rbY1B+2JunuvdMXMtm2dQHtl8rFMpN9 Ajri31aJlT5Gs7K9m22Kr8ASlsJOxAyOPQTK/WDgwszIKpR/BZAl/2mg3SwuNTTQmm7N8lgHl 3VM329ZDSxswxVskkHnaSQnPyWUcfLC83Yzh5D32S3RIQZ9a8sYigE4kc/Z/qvmzeL1zx1+K3 gCk69FNcRLKeCubnjUWSI4HEldythKJsFveS3uSibUQxWM2pBWSYm7RzTBwJPdTsba+FQVBNx GWIVCNBIhUzuyMPF44TcKFxOltkiEtq2hV7wdA7Q0uFbgQc2fau1cKOdQyK+P1zKvMR9Yzy Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, richard.henderson@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 09/07/2021 à 14:06, Mark Nelson a écrit : > We know that in the body of this if statement i is less than len, so > we really should be copying len - i bytes not i - len bytes. > > Fix this typo. > > Signed-off-by: Mark Nelson > --- > util/guest-random.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/guest-random.c b/util/guest-random.c > index 086115bd67..23643f86cc 100644 > --- a/util/guest-random.c > +++ b/util/guest-random.c > @@ -38,7 +38,7 @@ static int glib_random_bytes(void *buf, size_t len) > } > if (i < len) { > x = g_rand_int(rand); > - __builtin_memcpy(buf + i, &x, i - len); > + __builtin_memcpy(buf + i, &x, len - i); > } > return 0; > } > Applied to my trivial-patches branch. Thanks, Laurent