From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [qemu-web PATCH 6/7] Add link to "edit this page" for all pages
Date: Fri, 23 Oct 2020 19:07:11 +0200 [thread overview]
Message-ID: <d50d8fe4-c980-2765-7a37-feffff5bfb9a@redhat.com> (raw)
In-Reply-To: <20201023161912.GB463062@redhat.com>
On 23/10/20 18:19, Daniel P. Berrangé wrote:
>> I think this is a good idea *if* we switch to merge requests for website
>> edits---which isn't something I'm opposed to.
> Note if you disable merge requests, then the page we link to doesn't
> show a live editor. It merely shows the read-only source. Not as
> useful, at least the user can see which source file they need to
> touch in their fork, which is still a step forwards I think.
>
I agree, so I think if you change it to "View source" it's okay.
Paolo
next prev parent reply other threads:[~2020-10-23 17:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:29 [qemu-web PATCH 0/7] Tweaks to page footer and add "edit page" links Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 1/7] Convert files to UNIX line endings Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 2/7] gitlab: introduce a CI job to publish the site content Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 3/7] make all links be relative to the root Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 4/7] Make page header nav narrower Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 5/7] Simplify and restructure the page footer Daniel P. Berrangé
2020-10-23 15:46 ` Paolo Bonzini
2020-10-23 16:46 ` Daniel P. Berrangé
2020-10-23 17:19 ` Paolo Bonzini
2020-10-23 15:29 ` [qemu-web PATCH 6/7] Add link to "edit this page" for all pages Daniel P. Berrangé
2020-10-23 15:47 ` Paolo Bonzini
2020-10-23 16:19 ` Daniel P. Berrangé
2020-10-23 17:07 ` Paolo Bonzini [this message]
2020-10-23 15:29 ` [qemu-web PATCH 7/7] Add a CONTRIBUTING.md file as guidance for contributors Daniel P. Berrangé
2020-10-23 15:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d50d8fe4-c980-2765-7a37-feffff5bfb9a@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).