From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: sunilmut@microsoft.com, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] whpx: fix compilation
Date: Fri, 18 Dec 2020 14:07:27 +0100 [thread overview]
Message-ID: <d54e4e19-d199-a03d-ceab-0da9ba21ac48@redhat.com> (raw)
In-Reply-To: <CAMxuvaw=koNfQbhVpaHWt0nCZhMzy703X=Hhxw_gi2wCJyjciA@mail.gmail.com>
You're right that the headers _are_ included in whp-dispatch.h, so yeah
they do provide WHV_PARTITION_HANDLE which is the only thing that needs
API includes.
But in turn whpx_state is only needed for whpx_apic_in_platform(), so
the main issue is that sysemu/whpx.h is exposing unnecessary application
details. We can make two changes. First, make whpx_apic_in_platform()
a function instead of a macro, so that whpx_state can be moved to a new
header whpx-internal.h.
In fact, whp-dispatch.h and the new header can be merged, too. I'll
send two patches.
Paolo
next prev parent reply other threads:[~2020-12-18 13:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 8:46 [PATCH] whpx: fix compilation marcandre.lureau
2020-12-18 9:50 ` Paolo Bonzini
2020-12-18 10:08 ` Marc-André Lureau
2020-12-18 10:28 ` Paolo Bonzini
2020-12-18 11:07 ` Marc-André Lureau
2020-12-18 13:07 ` Paolo Bonzini [this message]
2020-12-18 11:25 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d54e4e19-d199-a03d-ceab-0da9ba21ac48@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sunilmut@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).