[PATCH] tests/functional: Use -no-shutdown in the hppa_seabios test

[PATCH] tests/functional: Use -no-shutdown in the hppa_seabios test

[Thomas Huth]

From: Thomas Huth <thuth@redhat.com>

qemu-system-hppa shuts down automatically when the BIOS is
unable to boot from any device. So this test currently fails
occasionally when QEMU already quit, but the test still
expected it to be around (e.g. to shut it down cleanly).
Adding a "-no-shutdown" seems to make it reliable.
While we're at it, also remove the stray "self.machine" in
there that does not have any purpose.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/test_hppa_seabios.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/functional/test_hppa_seabios.py b/tests/functional/test_hppa_seabios.py
index a44d1a3eebe..661b2464e13 100755
--- a/tests/functional/test_hppa_seabios.py
+++ b/tests/functional/test_hppa_seabios.py
@@ -17,9 +17,9 @@ class HppaSeabios(QemuSystemTest):
     def boot_seabios(self):
         mach = self.machine
         bits = self.MACH_BITS[mach]
+        self.vm.add_args('-no-shutdown')
         self.vm.set_console()
         self.vm.launch()
-        self.machine
         wait_for_console_pattern(self, f'SeaBIOS PA-RISC {bits}-bit Firmware')
         wait_for_console_pattern(self, f'Emulated machine:     HP {mach} ({bits}-bit')
 
-- 
2.49.0

Re: [PATCH] tests/functional: Use -no-shutdown in the hppa_seabios test

[Daniel P. Berrangé]

On Thu, May 08, 2025 at 08:09:18PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> qemu-system-hppa shuts down automatically when the BIOS is
> unable to boot from any device. So this test currently fails
> occasionally when QEMU already quit, but the test still
> expected it to be around (e.g. to shut it down cleanly).
> Adding a "-no-shutdown" seems to make it reliable.
> While we're at it, also remove the stray "self.machine" in
> there that does not have any purpose.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/test_hppa_seabios.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] tests/functional: Use -no-shutdown in the hppa_seabios test

[Philippe Mathieu-Daudé]

On 8/5/25 20:09, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> qemu-system-hppa shuts down automatically when the BIOS is
> unable to boot from any device. So this test currently fails
> occasionally when QEMU already quit, but the test still
> expected it to be around (e.g. to shut it down cleanly).
> Adding a "-no-shutdown" seems to make it reliable.
> While we're at it, also remove the stray "self.machine" in
> there that does not have any purpose.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/test_hppa_seabios.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/functional/test_hppa_seabios.py b/tests/functional/test_hppa_seabios.py
> index a44d1a3eebe..661b2464e13 100755
> --- a/tests/functional/test_hppa_seabios.py
> +++ b/tests/functional/test_hppa_seabios.py
> @@ -17,9 +17,9 @@ class HppaSeabios(QemuSystemTest):
>       def boot_seabios(self):
>           mach = self.machine
>           bits = self.MACH_BITS[mach]
> +        self.vm.add_args('-no-shutdown')
>           self.vm.set_console()
>           self.vm.launch()
> -        self.machine

Oops, thanks =)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>