From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5354EC433F5 for ; Thu, 23 Sep 2021 13:54:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B465D60FA0 for ; Thu, 23 Sep 2021 13:54:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B465D60FA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTPBB-00083p-Kc for qemu-devel@archiver.kernel.org; Thu, 23 Sep 2021 09:54:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTPAD-0007M3-W4 for qemu-devel@nongnu.org; Thu, 23 Sep 2021 09:53:26 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:42807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTPAC-000166-A9 for qemu-devel@nongnu.org; Thu, 23 Sep 2021 09:53:25 -0400 Received: from [192.168.100.1] ([82.142.21.142]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MIdW9-1mfpMl0JC1-00EfxS; Thu, 23 Sep 2021 15:53:22 +0200 Subject: Re: [PATCH v5 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge To: Mark Cave-Ayland , qemu-devel@nongnu.org References: <20210923091308.13832-1-mark.cave-ayland@ilande.co.uk> <20210923091308.13832-15-mark.cave-ayland@ilande.co.uk> <63b200b3-1690-cec2-d54b-7366073c64f3@ilande.co.uk> From: Laurent Vivier Message-ID: Date: Thu, 23 Sep 2021 15:53:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <63b200b3-1690-cec2-d54b-7366073c64f3@ilande.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:ILYjm6uBY2nO0BkJ/5kQ+XOOWG/JR7XYg2YULl6yDuUY6Q3Raxv diAIlH2JKhKk+MPuoDST0R39xLQEm7b820xVc3zRlMApxGqFc7ow5kjLxo5QSYrVFq8fvFM sf5Trup7PeBhdbq9LSTztFuHIz9KYpNXEvt8l5WX9dhEbWa3mmS8Q63yGimbNafjIG713vw rDKtDtaj+FN3GhqWBrd7Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:A5geK972PVQ=:uXnUkIl1/qAkR0l/Wl34Mz dAfuex/7ut1J5gK4VLCAKmu5AZM1ZVqmLU5hr6ZbLtxTGvBv49bsl7eVmBmcWo+PjHCUKm3u7 GFBZNAEIxymbYBEFA1UVG8rpzuabICyqAKYSSq4v7c6tmQ3OEVJWCaH1cM6iZv2CMmcX/NEvf Uv/1PfSJ/557YyLDkZ0nF2NW/ackh34fhJ3qYuZZIH2E9Q+PkQcD4i37FWFt3XiYotBnzQheu fMesH1/Fe1bwxSnAh0ho9cSU6RBY6dBbJWftVLVnd3YNOVSTDvTBi3xsAMutYzuQd0ZDl9oeM iU8Zs8Qo4eH9XJ+KgW20KHh8bQrW0JibKm/DWsgyq5jSSOR9X4ZnexBcWe3R+d46aU5rdCg6B FEDZyOoFZmi6TpcDleHNrYJvrMs1hdLhH3t28yukgFLXZoQsuLlTCQ3dJ95mkfsiGFhuojV/b Fw7cocO5xA5MEfshXftBvlTS82nukw5OJryWty9VKWw2u/afflcoH3SOvi7ErssvxQmF5x9iS Z3HWqVEy1AjYE5zVts0l8aVHxZSe5OwSC39vXlHDf2LEkXx08jxpe0/8v6i0t+T01F9yGG1X0 F2W/9KCdBHYPccyCGFQ58LrcP95f/XPmPU5XnKiWwE9wf6RsDxOn2zaiaXUWf0ZKmZp1JvE4w JzbwR6ie2EfKCAJXYoQkbtjpZd0hYCHxfFt6TVC5r6IHZlfBjxrJGABXO4p0GknKC66RN0kQT VcjLIU+9X9hq5EsOi3Trtxs+MBeZ17N3166KdA== Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 23/09/2021 à 14:50, Mark Cave-Ayland a écrit : > On 23/09/2021 11:35, Laurent Vivier wrote: > >> Le 23/09/2021 à 11:13, Mark Cave-Ayland a écrit : >>> This better reflects that the mac-nubus-bridge device is derived from the >>> nubus-bridge device, and that the structure represents the state of the bridge >>> device and not the Nubus itself. Also update the comment in the file header to >>> reflect that mac-nubus-bridge is specific to the Macintosh. >>> >>> Signed-off-by: Mark Cave-Ayland >>> Reviewed-by: Philippe Mathieu-Daudé >>> --- >>>   hw/nubus/mac-nubus-bridge.c         | 8 +++++--- >>>   include/hw/nubus/mac-nubus-bridge.h | 4 ++-- >>>   2 files changed, 7 insertions(+), 5 deletions(-) >>> >> >> >> Reviewed-by: Laurent Vivier >> >> (it could be merged with previous one) > > I like to try and keep renames on a per-device basis if possible, even if it's just to help rebasing > during development. Ok. No problem. > Other than that, is there anything else outstanding you think would require a v6 series? Except if you want to address comments from Philippe, I can collect this series and send a PR. Thanks, Laurent