qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Jonathan Cameron via <qemu-devel@nongnu.org>
Cc: Fan Ni <fan.ni@samsung.com>, Paolo Bonzini <pbonzini@redhat.com>,
	mst@redhat.com
Subject: Re: [PATCH 2/2] hw/cxl: Allow tracing component I/O accesses
Date: Fri, 24 Jan 2025 17:28:02 +0100	[thread overview]
Message-ID: <d5749a49-a12f-4485-b2f1-189b3d9cc89e@linaro.org> (raw)
In-Reply-To: <20250124162028.0000464b@huawei.com>

On 24/1/25 17:20, Jonathan Cameron wrote:
> On Thu, 23 Jan 2025 09:51:51 +0000
> Jonathan Cameron via <qemu-devel@nongnu.org> wrote:
> 
>> On Wed, 22 Jan 2025 07:56:24 +0100
>> Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>>> Map the component I/O region as UnimplementedDevice
>>> to be able to trace guest I/O accesses with '-d unimp'.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> I'm not that familiar with this infrastructure but seems
>> fine to me.
>>
>> I'd definitely be curious if anything is touching this space so
>> tracing may be helpful for that!
> Hi Philippe
> 
>>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Retract that.
> 
> Can't instantiate a CXL device with this patch because:
> 
> Device unimplemented-device can not be dynamically instantiated.

Hmm the qtests using CXL devices pass, how do you trigger that?

> 
> Reverting this patch on my tree fixes that.
> 
>>> ---
>>>   include/hw/cxl/cxl_component.h |  3 ++-
>>>   hw/cxl/cxl-component-utils.c   | 14 +++++++++++---
>>>   hw/cxl/Kconfig                 |  1 +
>>>   3 files changed, 14 insertions(+), 4 deletions(-)



  reply	other threads:[~2025-01-24 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22  6:56 [PATCH 0/2] hw/cxl: Add tracing for component I/O region Philippe Mathieu-Daudé
2025-01-22  6:56 ` [PATCH 1/2] hw/cxl: Remove unused component_registers::io_registers[] array Philippe Mathieu-Daudé
2025-01-23  9:49   ` Jonathan Cameron via
2025-01-22  6:56 ` [PATCH 2/2] hw/cxl: Allow tracing component I/O accesses Philippe Mathieu-Daudé
2025-01-23  9:51   ` Jonathan Cameron via
2025-01-24 16:20     ` Jonathan Cameron via
2025-01-24 16:28       ` Philippe Mathieu-Daudé [this message]
2025-01-31 19:07         ` Jonathan Cameron via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5749a49-a12f-4485-b2f1-189b3d9cc89e@linaro.org \
    --to=philmd@linaro.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=fan.ni@samsung.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).