From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF62C433E0 for ; Tue, 9 Jun 2020 08:36:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BEBB2081A for ; Tue, 9 Jun 2020 08:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e2DCH2z/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BEBB2081A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiZjv-0002S0-It for qemu-devel@archiver.kernel.org; Tue, 09 Jun 2020 04:36:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiZj0-0001kw-Vo for qemu-devel@nongnu.org; Tue, 09 Jun 2020 04:35:15 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33507 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiZiz-0001K8-TW for qemu-devel@nongnu.org; Tue, 09 Jun 2020 04:35:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591691713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Nnqw+NHCedKiAtpI+GeASnt9mqT1XRRNch7IstNkXzU=; b=e2DCH2z/3m7b3PtW66kJnh4rLoKx5kVwvNqKgeBtytg7WKBLACip2fu8JY0UCMKtw9lAKQ +BDpCrAD0CXpqJiaKvscVRd4l034L7ROqk3I7RTGj477gZ6bqY0BqbD/rYBPoUQvTzvrjJ tnt9u6EEXUjNM3VDclrXW8cS6dGFJ5w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-Ql76LgkDMGmGVsaCUocGmw-1; Tue, 09 Jun 2020 04:35:11 -0400 X-MC-Unique: Ql76LgkDMGmGVsaCUocGmw-1 Received: by mail-wr1-f71.google.com with SMTP id w16so8280998wru.18 for ; Tue, 09 Jun 2020 01:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Nnqw+NHCedKiAtpI+GeASnt9mqT1XRRNch7IstNkXzU=; b=JeYxQyYf8SedwuKxguY0rVTv/NIAzsfUR5ra8/MsFqmnYedWkSUls6exiqF9moKMVY Qm4+BEOe8xh68rV4poZaDAzn0kbXzbSGahhFyDU7lm19Z/aBOU7V2LFKyOr4oSq/9CgZ ruCPfbGuey2qklsDBquhqvn6JvAo13W1cgjf2rHhqcZtqj2eAbJEtdy6vyecwQq05opp fjiDD+Rt2Kf9rqec7TR4+aBsLFK1qkwINLo50h7XyNkNxAZ3DXVzmHe3duTLWhTEtYfq A74iv7aQIUebJXaqreKd5TclAJLIyTcIky2nMMNj5PyVVJ8oTIHlA4Z7SecJzJLnC3as X/Fg== X-Gm-Message-State: AOAM531/5BoCo7Sq1s1Bpy9BL95+kYKuCikbWbobxI83k/J0AYdAyYQN USWre+C+I2aPIcZnazAjx9vxSImjRMF1NykBt0yNuaUiMImCymWqTplsGVD93ZxHmUsH0FWSkJA j5eCU2o00NSKMFmU= X-Received: by 2002:a5d:49c4:: with SMTP id t4mr3076085wrs.127.1591691710222; Tue, 09 Jun 2020 01:35:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5B7d9hBWuRxMMEl8GE/cP7lLnHdUhvLTOYZQgnMkmQST3wKaoaszS0yI2HSrgKHJChBuRog== X-Received: by 2002:a5d:49c4:: with SMTP id t4mr3076072wrs.127.1591691710044; Tue, 09 Jun 2020 01:35:10 -0700 (PDT) Received: from [192.168.1.38] (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id s5sm2049294wme.37.2020.06.09.01.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2020 01:35:09 -0700 (PDT) Subject: Re: [PATCH v2 44/58] sysbus: New sysbus_realize(), sysbus_realize_and_unref() To: Markus Armbruster , qemu-devel@nongnu.org References: <20200529134523.8477-1-armbru@redhat.com> <20200529134523.8477-45-armbru@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Tue, 9 Jun 2020 10:35:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200529134523.8477-45-armbru@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/09 01:38:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/29/20 3:45 PM, Markus Armbruster wrote: > Sysbus devices almost always plug into the main system bus. > qdev_create() even has a convenience feature to make that easy: a null > bus argument gets replaced by the main system bus. qdev_realize() and > qdev_realize_and_unref() do the same. > > We can do better. Provide convenience wrappers around qdev_realize() > and qdev_realize_and_unref() that don't take a @bus argument. They > always pass the main system bus. > > Signed-off-by: Markus Armbruster > --- > include/hw/sysbus.h | 4 +++- > hw/core/sysbus.c | 14 ++++++++++++-- > 2 files changed, 15 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé