From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmMCF-0000Cg-KV for qemu-devel@nongnu.org; Tue, 20 Sep 2016 10:39:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmMC9-0007vf-FL for qemu-devel@nongnu.org; Tue, 20 Sep 2016 10:38:54 -0400 References: <1474306544-24708-1-git-send-email-berrange@redhat.com> <1474306544-24708-2-git-send-email-berrange@redhat.com> <5a389739-00eb-48a2-188b-31030337e3eb@redhat.com> <20160920093635.GA25490@redhat.com> <6a34a3f9-7ac4-ab53-1921-40a8e21a6a88@redhat.com> <20160920141528.GO25490@redhat.com> From: Eric Blake Message-ID: Date: Tue, 20 Sep 2016 09:38:33 -0500 MIME-Version: 1.0 In-Reply-To: <20160920141528.GO25490@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sXgwLF8MLCoEs9b19suUjruLU2LNK95LB" Subject: Re: [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sXgwLF8MLCoEs9b19suUjruLU2LNK95LB From: Eric Blake To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change References: <1474306544-24708-1-git-send-email-berrange@redhat.com> <1474306544-24708-2-git-send-email-berrange@redhat.com> <5a389739-00eb-48a2-188b-31030337e3eb@redhat.com> <20160920093635.GA25490@redhat.com> <6a34a3f9-7ac4-ab53-1921-40a8e21a6a88@redhat.com> <20160920141528.GO25490@redhat.com> In-Reply-To: <20160920141528.GO25490@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/20/2016 09:15 AM, Daniel P. Berrange wrote: >>> I guess we could keep things simple by not inventing a new format, >>> but instead of using 'check.time', use 'check.time.$FORMAT-$PROTOCOL'= >>> eg 'check.time.qcow2-file' >> >> Seems more palatable. Lots of files rather than lots of lines in a >> single file; searching is now fast (if you can come up with the right >> file name, the OS does the searching for you rather than us having to >> figure out which (if any) portion of a large file applies). We may >> still want a command for easily cleaning everything, and if we do swit= ch >> to new file names, we'll still want to clean up the old files. >=20 > Isn't that command called 'git clean -f' - if we remove 'check.time' > from the gitignore file, it'll be deleted by a git clean, without > needing to ass the -i flag. I don't think we really need to reinvent > a special way to clean just these timing files, particularly since > they are not large. I'd still rather have the gitignore file ignore anything that we don't want to check into the tree (I'm a big fan of 'git add -a .', and hate it when non-ignored generated files interfere with that; yes I know I can munge .git/info/exclude locally, but it feels cleaner when generated files are ignored at the project level). But yes, relying on git to do the cleanup is fine from my point of view. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sXgwLF8MLCoEs9b19suUjruLU2LNK95LB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4UnpAAoJEKeha0olJ0NqEFkH/0+NJ7IoH39gNn5IhaxgP8XM nEpKWLMoowkkeZgBsRhUt/xYkzpIKG7mWH+iXF9pARjXCQYAkLvbNDJ0BOozPAVh GeZoXV2evXaS8/SYyVXe61ITEYhpE7aDEXqDg/I39D57mBj8hryCh9sLdjQ/KnZ3 f31tCuwMSmi5X8wc2yumvFcWXiw7G8F/C1niRjFBOtl6syRjSEvvjXLHDLLQCsMa 2agL/wSFCm/3I0zbGBNZD8HnuXhLmKxn1vjzovcQAap/oAuuii/5e0dJeE933LWU OQ5sPVzwf5H6FY2PD4xeIsfIfFs3p1rXPNx4BtoEad81zyFfkigt5XrY8hgV0GY= =wEcU -----END PGP SIGNATURE----- --sXgwLF8MLCoEs9b19suUjruLU2LNK95LB--