From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C408C4338F for ; Wed, 4 Aug 2021 14:13:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DC6A60EE8 for ; Wed, 4 Aug 2021 14:13:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1DC6A60EE8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBHeN-0004LU-BO for qemu-devel@archiver.kernel.org; Wed, 04 Aug 2021 10:13:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBHdh-0003ff-DB for qemu-devel@nongnu.org; Wed, 04 Aug 2021 10:12:57 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:34135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBHdf-0001Lb-QC for qemu-devel@nongnu.org; Wed, 04 Aug 2021 10:12:57 -0400 Received: from [192.168.100.1] ([82.142.6.46]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1Mofx1-1mvbwW0Z4r-00p5sY; Wed, 04 Aug 2021 16:12:49 +0200 Subject: Re: [PATCH] linux-user/elfload: byteswap i386 registers when dumping core To: Peter Maydell References: <20210803172013.148446-1-iii@linux.ibm.com> From: Laurent Vivier Message-ID: Date: Wed, 4 Aug 2021 16:12:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:3LYC9wljIiRHpETzL4+Z5cmcV7kFIXzkb8btIzRGskz4yfpocY8 IGFwH5c8D9+88yiZladB6ske6ll8Ozr4pY3nfbo4YT0wzomCIKGnwfw5cKiE88F5n9545Xu rZ31C5/enX3tDC7z83anCLPYxFIXN4x4n8WA2wyOMfauw+fdLbdgzPwYFxIoojW9uCmBcmI zORq99ZBKS6/m5HjkfA+g== X-UI-Out-Filterresults: notjunk:1;V03:K0:dQPFUws2BH4=:t8CNIgwzU6F5mWOuYrFqe1 FcxuCd51ygWD2W7YpD+484D6BOwSUEpeyqvbJXdR1L90bzj85nMnHPZLXN336o3FHN6+xtknF oVaf+ZdHVhz5G2mpsWgXk8Fc6yJlhezGITQhLxvuoQfnSpAhkFj0P7Y9tJhLAjB0OVnl3UIDE /oPzhaB+cpG6IkAK5V9RbeSp2XeTMTQN0Ifv702e1eUJ+x7CaKRj6+jyJO/+xQQXNG8CEu5t2 d0zjNttB43jctk4Ehsqq0PCn6c8kR0nO2AwPWRcfZfbRI1OV/DEfzXROKDufy/14dnRNLV0pX wFMsAdrrmt1U7b4dGokPELzzdKS2J9CcUVS5od0v1XsyZue/7VlvQAp3WvAwHPdO/4QDFSjB9 gppdOcXx7yoAtiv75p7mrKndcMuXNzZG03QCbTI0e6PC6J0upqjcmUPu93euigHh50/yn1/2U 7pW57U/93cgNiZrE5LjVASbTX3LTdy9KYkCm7WFJKkoz/6yev4aEmEndmXJOs2UloGKcE2Fwq AiDRTSHErxerRPDCrxXo7r3SL3HMtRro1wK5OJyu5hK+vbjk9vqxaORmhX7FHLScfmPfxZK4K lC2WfhnJaHxvhaQXSzb68x+9LOCeaPm5tHLDL4M/XDV/otv0wt5s8Q1jbUr+rtjHh31KHkk7I 28N2A2W+a4+j0dxQ4KC7kFKH0THw22p/HT7DjWQhHd7l1Szeb8P04NuE9ZW/mnus5HWCXcChS sj8xgYjqZd2YfWMDBnQBzCktrKZu4iBMhEetvCE54ROXSdQNF0lbWrw7RbycrvbR9uwqDzdnH 9XnsSot02AH1JjFVgMpn1/dChh/4FVGBlrOxk7+/E/llPQ2eHtmxKfnzoU10zwE/hDpWRL3 Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.132, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , QEMU Developers , Ilya Leoshkevich , Andreas Krebbel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 03/08/2021 à 20:34, Peter Maydell a écrit : > On Tue, 3 Aug 2021 at 18:21, Ilya Leoshkevich wrote: >> >> Core dumps from emulating x86_64 on big-endian hosts contain incorrect >> register values. >> >> Signed-off-by: Ilya Leoshkevich > > > Looks like these two were the only two guest arch versions of this > function that were missing the tswapreg calls... > > Reviewed-by: Peter Maydell Do we want this in 6.1? Thanks, Laurent